Support ledger friendly signatures in pallet-limit-orders#2809
Open
girazoki wants to merge 4 commits into
Open
Support ledger friendly signatures in pallet-limit-orders#2809girazoki wants to merge 4 commits into
girazoki wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR the pallet-limit-orders only supports injecting the signature as the signature over the entire payload of the order.
After this PR the siganture of the form:
blake256(payload)
is also supported, as well as ed25519 signatures. the reason for this is that ledger wraps sigantures over these wrappers (and frankly, other offchain signing tools also might)
I maintained both for compatibility issues, but in theory the previous signature verification can be removed
Type of Change
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly