Remove edpm_iscsid_image container references by katarimanojk · Pull Request #1923 · openstack-k8s-operators/openstack-operator

katarimanojk · 2026-05-19T10:48:50Z

The iscsid service has been moved from container to host-based deployment in edpm-ansible (PR #984). This change removes or deprecates all references to EdpmIscsidImage throughout the codebase:

Removed from service containerImageFields (nova, run-os)
Removed from inventory variable assignment
Deprecated API fields with comments (preserves backward compatibility)
Updated sample configurations with deprecation notes
Removed from documentation
Commented out build-time image variables
Updated tests to remove EdpmIscsidImage assertions

The EdpmIscsidImage field remains in the API types but is marked as deprecated to avoid breaking changes for existing deployments.

Related: openstack-k8s-operators/edpm-ansible#984

Closes: https://redhat.atlassian.net/browse/OSPRH-17429

openshift-ci · 2026-05-19T10:49:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katarimanojk
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-05-19T10:49:12Z

OpenStackControlPlane CRD Size Report

Metric	Value
CRD JSON size	350002 bytes (342KB)
Base branch size	350002 bytes
Change	+0.00%
Status	yellow — growing

Threshold reference

Color	Range	Meaning
🟢 green	< 300KB	Comfortable
🟡 yellow	300–400KB	Growing
🟠 orange	400–750KB	Concerning
🔴 red	> 750KB	Approaching 1.5MB etcd limit (cut in half to allow space for update)

katarimanojk · 2026-06-03T07:27:50Z

recheck

katarimanojk · 2026-06-23T11:59:51Z

recheck

centosinfra-prod-github-app · 2026-06-23T12:09:31Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/68fe43836bb04bf48a9d6f71e2cd2570

❌ openstack-k8s-operators-content-provider FAILURE in 7m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ openstack-operator-docs-preview SUCCESS in 3m 40s
⚠️ openstack-operator-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

katarimanojk · 2026-06-24T06:43:19Z

recheck

The iscsid service has been moved from container to host-based deployment in edpm-ansible (PR openstack-k8s-operators#984). This change removes or deprecates all references to EdpmIscsidImage throughout the codebase: - Removed from service containerImageFields (nova, run-os) - Removed from inventory variable assignment - Deprecated API fields with comments (preserves backward compatibility) - Updated sample configurations with deprecation notes - Removed from documentation - Commented out build-time image variables - Updated tests to remove EdpmIscsidImage assertions The EdpmIscsidImage field remains in the API types but is marked as deprecated to avoid breaking changes for existing deployments. Related: openstack-k8s-operators/edpm-ansible#984 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

katarimanojk · 2026-06-29T06:14:47Z

/test openstack-operator-build-deploy-kuttl-4-18

openshift-ci · 2026-06-29T08:46:54Z

@katarimanojk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-18	`349e3de`	link	true	`/test openstack-operator-build-deploy-kuttl-4-18`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

slagle

Other than the deprecated fields themselves, I don't think we need to leave commented out lines where we have removed references to the image.

slagle · 2026-06-29T11:03:30Z

-          value: quay.io/podified-antelope-centos9/openstack-iscsid:current-podified
+        # Deprecated: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT is no longer used - iscsid now runs on the host
+        # - name: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT
+        #   value: quay.io/podified-antelope-centos9/openstack-iscsid:current-podified


why not just remove this from here? I don't think it needs a deprecation warning.

slagle · 2026-06-29T11:03:44Z

          timesync_ntp_servers:
            - hostname: clock.redhat.com
-          edpm_iscsid_image: '{{ registry_url }}/openstack-iscsid:{{ image_tag }}'
+          # edpm_iscsid_image is no longer used - iscsid now runs on the host instead of in a container


just remove the line

slagle · 2026-06-29T11:03:58Z

          # edpm_bootstrap_command: |
          #       subscription-manager register --username {{ subscription_manager_username }} --password {{ subscription_manager_password }}
-          edpm_iscsid_image: '{{ registry_url }}/openstack-iscsid:{{ image_tag }}'
+          # edpm_iscsid_image is no longer used - iscsid now runs on the host instead of in a container


slagle · 2026-06-29T11:04:35Z

 export RELATED_IMAGE_EDPM_FRR_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-frr:current-podified
-export RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-iscsid:current-podified
+# Deprecated: RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT is no longer used - iscsid now runs on the host
+# export RELATED_IMAGE_EDPM_ISCSID_IMAGE_URL_DEFAULT=quay.io/podified-antelope-centos9/openstack-iscsid:current-podified


slagle · 2026-06-29T11:06:48Z

-	if template.Ansible.AnsibleVars["edpm_iscsid_image"] == nil {
-		group.Vars["edpm_iscsid_image"] = containerImages.EdpmIscsidImage
-	}
+	// edpm_iscsid_image is no longer used - iscsid now runs on the host instead of in a container


i don't think we need a comment here

openshift-ci Bot requested review from abays and rabi May 19, 2026 10:48

katarimanojk marked this pull request as draft May 19, 2026 10:49

openshift-ci Bot added the do-not-merge/work-in-progress label May 19, 2026

katarimanojk force-pushed the iscsid_container_cleanup branch from 63799fb to 6c7fc49 Compare May 28, 2026 08:46

katarimanojk marked this pull request as ready for review May 28, 2026 11:50

openshift-ci Bot removed the do-not-merge/work-in-progress label May 28, 2026

openshift-ci Bot requested a review from stuggi May 28, 2026 11:50

katarimanojk force-pushed the iscsid_container_cleanup branch from 6c7fc49 to bfcabc4 Compare June 2, 2026 16:35

katarimanojk force-pushed the iscsid_container_cleanup branch from bfcabc4 to 116feb1 Compare June 3, 2026 11:09

stuggi requested review from slagle and removed request for abays and stuggi June 15, 2026 07:42

katarimanojk force-pushed the iscsid_container_cleanup branch from 116feb1 to 349e3de Compare June 26, 2026 09:25

slagle reviewed Jun 29, 2026

View reviewed changes

Uh oh!

Conversation

katarimanojk commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenStackControlPlane CRD Size Report

Uh oh!

katarimanojk commented Jun 3, 2026

Uh oh!

katarimanojk commented Jun 23, 2026

Uh oh!

centosinfra-prod-github-app Bot commented Jun 23, 2026

Uh oh!

katarimanojk commented Jun 24, 2026

Uh oh!

katarimanojk commented Jun 29, 2026

Uh oh!

openshift-ci Bot commented Jun 29, 2026

Uh oh!

slagle left a comment

Choose a reason for hiding this comment

Uh oh!

slagle Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

slagle Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

slagle Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

slagle Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

slagle Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

katarimanojk commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading