Make e2e-metal-ipi-ovn-virtualmedia mandatory for CBO#82155
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 20, 2026
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (12)
🚧 Files skipped from review as they are similar to previous changes (10)
WalkthroughThe ChangesVirtualmedia CI scheduling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
|
/approve |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
/pj-rehearse ack we're not testing here, we know it will fail, we need to re-enable it to test it in CBO |
Contributor
|
@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
elfosardo
force-pushed
the
re-enable-vmedia-cbo
branch
from
July 20, 2026 15:46
30d9ec6 to
edea223
Compare
openshift-merge-bot
Bot
removed
the
rehearsals-ack
Contributor
Author
|
/hold |
openshift-ci
Bot
added
do-not-merge/hold
elfosardo
force-pushed
the
re-enable-vmedia-cbo
branch
from
July 20, 2026 15:59
edea223 to
1d4c892
Compare
Contributor
Author
|
/unhold |
openshift-ci
Bot
added
approved
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
…perator The virtualmedia job was unintentionally made optional in 2021 as part of a bulk "sync optional field from jobs to ci-op config" change (48e313a). Restore it as a required presubmit across all active releases (4.15 through 5.1 and main).
elfosardo
force-pushed
the
re-enable-vmedia-cbo
branch
from
July 20, 2026 18:06
1d4c892 to
01aeb9a
Compare
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
removed
the
rehearsals-ack
Contributor
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@elfosardo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
fracappa
pushed a commit
to fracappa/release
that referenced
this pull request
Jul 22, 2026
…perator (openshift#82155) The virtualmedia job was unintentionally made optional in 2021 as part of a bulk "sync optional field from jobs to ci-op config" change (48e313a). Restore it as a required presubmit across all active releases (4.15 through 5.1 and main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtualmedia job was unintentionally made optional in 2021 as part of a bulk "sync optional field from jobs to ci-op config" change (48e313a). Restore it as a required presubmit across all active releases (4.15 through 5.1 and main).
Summary by CodeRabbit
Re-enables
e2e-metal-ipi-ovn-virtualmediaas a required presubmit forcluster-baremetal-operatoracrossmainand release branches 4.15–5.1 by updating the CI job definitions inci-operator/config/openshift/cluster-baremetal-operator/*.Practically, the job is no longer marked
optionaland is no longer disabled viaalways_run: false; instead it will be selected for CBO runs when code/functional changes are present. To avoid unnecessary runs on documentation/metadata-only changes, each job now addsskip_if_only_changedso it’s skipped when the PR only modifies markdown and top-level governance files (matching the\.md$|^(DCO|LICENSE|OWNERS|PROJECT)$pattern). The rest of the job wiring (including the intranet capability and underlyingbaremetalds-e2e-virtualmediaworkflow steps) remains unchanged.