Skip to content

Add Prow presubmit CI for migtools/kopia oadp-1.3 through 1.6#81944

Merged
openshift-merge-bot[bot] merged 6 commits into
openshift:mainfrom
Joeavaikath:add-kopia-1.4-presubmit
Jul 21, 2026
Merged

Add Prow presubmit CI for migtools/kopia oadp-1.3 through 1.6#81944
openshift-merge-bot[bot] merged 6 commits into
openshift:mainfrom
Joeavaikath:add-kopia-1.4-presubmit

Conversation

@Joeavaikath

@Joeavaikath Joeavaikath commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Add go build presubmit jobs for migtools/kopia on branches oadp-1.3, 1.4, 1.5, and 1.6. Also adds oadp-1.3 to the Tide config. Removes stale rebasebot periodic configs for oadp-1.5 and oadp-dev.

Problem: migtools/kopia has no Prow presubmit jobs on any branch. PR #39 merged on oadp-1.4 with a broken build — a carry commit downgraded prometheus/common from v0.52.3 to v0.44.0, breaking cli/observability_flags.go which uses expfmt.NewFormat (introduced in v0.46.0). All GitHub Actions CI checks failed but the merge wasn't gated.

What this adds per branch:

  • ci/prow/build (required) — go build ./... compilation gate

All branches use konveyor/builder:ubi9-v1.26 since all kopia release branches require Go 1.26+.

Files

ci-operator configs (new):

  • migtools-kopia-oadp-1.3.yaml
  • migtools-kopia-oadp-1.4.yaml
  • migtools-kopia-oadp-1.5.yaml
  • migtools-kopia-oadp-1.6.yaml

Generated presubmit jobs (new):

  • migtools-kopia-oadp-1.3-presubmits.yaml
  • migtools-kopia-oadp-1.4-presubmits.yaml
  • migtools-kopia-oadp-1.5-presubmits.yaml
  • migtools-kopia-oadp-1.6-presubmits.yaml

Removed (stale rebasebot periodics):

  • migtools-kopia-oadp-1.5__periodics.yaml
  • migtools-kopia-oadp-dev__periodics.yaml

Tide config (modified):

  • Added oadp-1.3 to _prowconfig.yaml includedBranches

/cc @kaovilai

Summary by CodeRabbit

Adds required Prow presubmit coverage for migtools/kopia branches oadp-1.3 through oadp-1.6 by generating go build ./... jobs per branch. Each branch’s presubmit uses the konveyor/builder:ubi9-v1.26 build root image with standard CPU/memory request/limit defaults, and introduces matching ci-operator configuration + generated presubmit job YAMLs under ci-operator/config/... and ci-operator/jobs/.... This restores merge gating after the previously merged broken oadp-1.4 build.

Updates Tide configuration (core-services/prow/02_config/migtools/kopia/_prowconfig.yaml) to include oadp-1.3 in includedBranches.

Removes stale Kopia rebasebot periodic CI configurations and generated jobs for oadp-1.5 and oadp-dev (deleted __periodics inputs under ci-operator/config/... and *-periodics.yaml outputs under ci-operator/jobs/...).

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: eb8d812b-f83d-41b9-b35b-e293b4fbcaed

📥 Commits

Reviewing files that changed from the base of the PR and between d81bf55 and 2e046cc.

📒 Files selected for processing (6)
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.3.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.4.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.5.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.5__periodics.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.6.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-dev__periodics.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.5__periodics.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-dev__periodics.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.6.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.5.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.3.yaml
  • ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.4.yaml

Walkthrough

Adds Kopia CI configurations for OADP branches 1.3 through 1.6, including builder images, resource defaults, Go build steps, and metadata. Tide now includes OADP 1.3, while obsolete OADP 1.5 and development periodic configurations are removed.

Changes

Kopia OADP CI

Layer / File(s) Summary
Branch CI build configurations
ci-operator/config/migtools/kopia/migtools-kopia-oadp-1.3.yaml, ...-1.4.yaml, ...-1.5.yaml, ...-1.6.yaml
Adds branch-specific builder images, resource requests and limits, required go build ./... steps, and generated repository metadata.
Tide branch and periodic configuration updates
core-services/prow/02_config/migtools/kopia/_prowconfig.yaml, ci-operator/config/migtools/kopia/*__periodics.yaml
Adds oadp-1.3 to the Kopia Tide query and removes the OADP 1.5 and development periodic configurations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: rehearsals-ack

Suggested reviewers: sseago

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding Prow presubmit CI for migtools/kopia across oadp-1.3 through oadp-1.6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only changes CI/prow YAML files; no Go/Ginkgo test titles were added or modified, so there are no dynamic names to flag.
Test Structure And Quality ✅ Passed PASS: The PR only changes CI/prow YAML; no Ginkgo test code or test blocks were added, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed The PR only changes CI/prow YAML; no Ginkgo e2e test code or MicroShift-unsupported API usage was added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI/prow YAML and generated presubmit configs changed; no new Ginkgo e2e tests or topology-sensitive code was added.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds/updates CI and Prow configs; the generated presubmits use a generic kubernetes agent with no node selectors, affinity, or topology-spread rules.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML config; no Go binaries or suite setup code with stdout writes were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo/e2e test code changed; only ci/prow YAML configs were added/edited, with no IPv4 or external-network assumptions found.
No-Weak-Crypto ✅ Passed PR only adds/removes CI YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret comparisons appear in the changed files or diff.
Container-Privileges ✅ Passed Changed YAMLs add only build_root/resources/tests; none set privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed Touched YAMLs only change builder tags/CI metadata; no log statements or sensitive fields appear in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Joeavaikath Joeavaikath reopened this Jul 15, 2026
@Joeavaikath
Joeavaikath marked this pull request as ready for review July 15, 2026 14:19
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@openshift-ci
openshift-ci Bot requested review from kaovilai and sseago July 15, 2026 14:21
@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Joeavaikath Joeavaikath changed the title Add Prow presubmit CI for migtools/kopia oadp-1.4 Add Prow presubmit CI for migtools/kopia oadp-1.3 through 1.6 Jul 15, 2026
@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-migtools-kopia-oadp-1.4-build

1 similar comment
@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-migtools-kopia-oadp-1.4-build

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-migtools-kopia-oadp-1.5-build

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-migtools-kopia-oadp-1.6-build

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

image_stream_tag:
name: builder
namespace: konveyor
tag: ubi9-v1.25

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get everything on 1.26 sir

@weshayutin weshayutin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick nit.. golang 1.26

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@Joeavaikath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/migtools/kopia/oadp-1.4/vet 214f1c9 link unknown /pj-rehearse pull-ci-migtools-kopia-oadp-1.4-vet
ci/rehearse/migtools/kopia/oadp-1.3/vet 214f1c9 link unknown /pj-rehearse pull-ci-migtools-kopia-oadp-1.3-vet
ci/rehearse/periodic-ci-migtools-kopia-oadp-1.5-periodics-rebasebot 214f1c9 link unknown /pj-rehearse periodic-ci-migtools-kopia-oadp-1.5-periodics-rebasebot

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/retest

@kaovilai kaovilai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2026
Joeavaikath and others added 6 commits July 21, 2026 10:51
Add ci-operator config and generated presubmit jobs for the
migtools/kopia repository on the oadp-1.4 branch. This adds a
required `build` test (go build ./...) and an optional `vet` test
(go vet ./...) to catch compilation failures before merge.

The vet test is marked optional because the rebase config has
GO_VET_SKIP=1 for oadp-1.4, indicating known vet issues.

Uses the ubi9-v1.25 builder image since oadp-1.4 go.mod requires
Go 1.25. No images section is needed as kopia is a library
dependency, not a built image.
Add build and vet presubmit jobs for the remaining kopia release
branches. Also add oadp-1.3 to the Tide branch list.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds cluster: build01 field required by CI formatting checks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Joeavaikath
Joeavaikath force-pushed the add-kopia-1.4-presubmit branch from d81bf55 to 2e046cc Compare July 21, 2026 14:56
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Joeavaikath: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-migtools-kopia-oadp-1.3-build migtools/kopia presubmit Presubmit changed
pull-ci-migtools-kopia-oadp-1.4-build migtools/kopia presubmit Presubmit changed
pull-ci-migtools-kopia-oadp-1.5-build migtools/kopia presubmit Presubmit changed
pull-ci-migtools-kopia-oadp-1.6-build migtools/kopia presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kaovilai

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Joeavaikath

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit d752f46 into openshift:main Jul 21, 2026
24 checks passed
@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@Joeavaikath: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-migtools-kopia-_prowconfig.yaml using file core-services/prow/02_config/migtools/kopia/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-migtools-kopia-_prowconfig.yaml using file core-services/prow/02_config/migtools/kopia/_prowconfig.yaml
Details

In response to this:

Summary

Add go build presubmit jobs for migtools/kopia on branches oadp-1.3, 1.4, 1.5, and 1.6. Also adds oadp-1.3 to the Tide config. Removes stale rebasebot periodic configs for oadp-1.5 and oadp-dev.

Problem: migtools/kopia has no Prow presubmit jobs on any branch. PR #39 merged on oadp-1.4 with a broken build — a carry commit downgraded prometheus/common from v0.52.3 to v0.44.0, breaking cli/observability_flags.go which uses expfmt.NewFormat (introduced in v0.46.0). All GitHub Actions CI checks failed but the merge wasn't gated.

What this adds per branch:

  • ci/prow/build (required) — go build ./... compilation gate

All branches use konveyor/builder:ubi9-v1.26 since all kopia release branches require Go 1.26+.

Files

ci-operator configs (new):

  • migtools-kopia-oadp-1.3.yaml
  • migtools-kopia-oadp-1.4.yaml
  • migtools-kopia-oadp-1.5.yaml
  • migtools-kopia-oadp-1.6.yaml

Generated presubmit jobs (new):

  • migtools-kopia-oadp-1.3-presubmits.yaml
  • migtools-kopia-oadp-1.4-presubmits.yaml
  • migtools-kopia-oadp-1.5-presubmits.yaml
  • migtools-kopia-oadp-1.6-presubmits.yaml

Removed (stale rebasebot periodics):

  • migtools-kopia-oadp-1.5__periodics.yaml
  • migtools-kopia-oadp-dev__periodics.yaml

Tide config (modified):

  • Added oadp-1.3 to _prowconfig.yaml includedBranches

/cc @kaovilai

Summary by CodeRabbit

Adds required Prow presubmit coverage for migtools/kopia branches oadp-1.3 through oadp-1.6 by generating go build ./... jobs per branch. Each branch’s presubmit uses the konveyor/builder:ubi9-v1.26 build root image with standard CPU/memory request/limit defaults, and introduces matching ci-operator configuration + generated presubmit job YAMLs under ci-operator/config/... and ci-operator/jobs/.... This restores merge gating after the previously merged broken oadp-1.4 build.

Updates Tide configuration (core-services/prow/02_config/migtools/kopia/_prowconfig.yaml) to include oadp-1.3 in includedBranches.

Removes stale Kopia rebasebot periodic CI configurations and generated jobs for oadp-1.5 and oadp-dev (deleted __periodics inputs under ci-operator/config/... and *-periodics.yaml outputs under ci-operator/jobs/...).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fracappa pushed a commit to fracappa/release that referenced this pull request Jul 22, 2026
…ift#81944)

* Add Prow presubmit CI for migtools/kopia oadp-1.4

Add ci-operator config and generated presubmit jobs for the
migtools/kopia repository on the oadp-1.4 branch. This adds a
required `build` test (go build ./...) and an optional `vet` test
(go vet ./...) to catch compilation failures before merge.

The vet test is marked optional because the rebase config has
GO_VET_SKIP=1 for oadp-1.4, indicating known vet issues.

Uses the ubi9-v1.25 builder image since oadp-1.4 go.mod requires
Go 1.25. No images section is needed as kopia is a library
dependency, not a built image.

* Add Prow presubmit CI for migtools/kopia oadp-1.3, 1.5, 1.6

Add build and vet presubmit jobs for the remaining kopia release
branches. Also add oadp-1.3 to the Tide branch list.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate kopia presubmit jobs with sanitize-prow-jobs

Adds cluster: build01 field required by CI formatting checks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove vet presubmit, keep only build gate

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Remove kopia rebasebot periodic jobs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Update build root to ubi9-v1.26 for Go 1.26 support

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants