Add Prow presubmit CI for migtools/kopia oadp-1.3 through 1.6#81944
Conversation
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughAdds Kopia CI configurations for OADP branches 1.3 through 1.6, including builder images, resource defaults, Go build steps, and metadata. Tide now includes OADP 1.3, while obsolete OADP 1.5 and development periodic configurations are removed. ChangesKopia OADP CI
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-migtools-kopia-oadp-1.4-build |
1 similar comment
|
/pj-rehearse pull-ci-migtools-kopia-oadp-1.4-build |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-migtools-kopia-oadp-1.5-build |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-migtools-kopia-oadp-1.6-build |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| image_stream_tag: | ||
| name: builder | ||
| namespace: konveyor | ||
| tag: ubi9-v1.25 |
There was a problem hiding this comment.
let's get everything on 1.26 sir
weshayutin
left a comment
There was a problem hiding this comment.
quick nit.. golang 1.26
|
@Joeavaikath: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
Add ci-operator config and generated presubmit jobs for the migtools/kopia repository on the oadp-1.4 branch. This adds a required `build` test (go build ./...) and an optional `vet` test (go vet ./...) to catch compilation failures before merge. The vet test is marked optional because the rebase config has GO_VET_SKIP=1 for oadp-1.4, indicating known vet issues. Uses the ubi9-v1.25 builder image since oadp-1.4 go.mod requires Go 1.25. No images section is needed as kopia is a library dependency, not a built image.
Add build and vet presubmit jobs for the remaining kopia release branches. Also add oadp-1.3 to the Tide branch list. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds cluster: build01 field required by CI formatting checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d81bf55 to
2e046cc
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@Joeavaikath: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Joeavaikath: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ift#81944) * Add Prow presubmit CI for migtools/kopia oadp-1.4 Add ci-operator config and generated presubmit jobs for the migtools/kopia repository on the oadp-1.4 branch. This adds a required `build` test (go build ./...) and an optional `vet` test (go vet ./...) to catch compilation failures before merge. The vet test is marked optional because the rebase config has GO_VET_SKIP=1 for oadp-1.4, indicating known vet issues. Uses the ubi9-v1.25 builder image since oadp-1.4 go.mod requires Go 1.25. No images section is needed as kopia is a library dependency, not a built image. * Add Prow presubmit CI for migtools/kopia oadp-1.3, 1.5, 1.6 Add build and vet presubmit jobs for the remaining kopia release branches. Also add oadp-1.3 to the Tide branch list. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Regenerate kopia presubmit jobs with sanitize-prow-jobs Adds cluster: build01 field required by CI formatting checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Remove vet presubmit, keep only build gate Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Remove kopia rebasebot periodic jobs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update build root to ubi9-v1.26 for Go 1.26 support Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Add
go buildpresubmit jobs formigtools/kopiaon branches oadp-1.3, 1.4, 1.5, and 1.6. Also adds oadp-1.3 to the Tide config. Removes stale rebasebot periodic configs for oadp-1.5 and oadp-dev.Problem: migtools/kopia has no Prow presubmit jobs on any branch. PR #39 merged on oadp-1.4 with a broken build — a carry commit downgraded
prometheus/commonfrom v0.52.3 to v0.44.0, breakingcli/observability_flags.gowhich usesexpfmt.NewFormat(introduced in v0.46.0). All GitHub Actions CI checks failed but the merge wasn't gated.What this adds per branch:
ci/prow/build(required) —go build ./...compilation gateAll branches use
konveyor/builder:ubi9-v1.26since all kopia release branches require Go 1.26+.Files
ci-operator configs (new):
migtools-kopia-oadp-1.3.yamlmigtools-kopia-oadp-1.4.yamlmigtools-kopia-oadp-1.5.yamlmigtools-kopia-oadp-1.6.yamlGenerated presubmit jobs (new):
migtools-kopia-oadp-1.3-presubmits.yamlmigtools-kopia-oadp-1.4-presubmits.yamlmigtools-kopia-oadp-1.5-presubmits.yamlmigtools-kopia-oadp-1.6-presubmits.yamlRemoved (stale rebasebot periodics):
migtools-kopia-oadp-1.5__periodics.yamlmigtools-kopia-oadp-dev__periodics.yamlTide config (modified):
oadp-1.3to_prowconfig.yamlincludedBranches/cc @kaovilai
Summary by CodeRabbit
Adds required Prow presubmit coverage for
migtools/kopiabranchesoadp-1.3throughoadp-1.6by generatinggo build ./...jobs per branch. Each branch’s presubmit uses thekonveyor/builder:ubi9-v1.26build root image with standard CPU/memory request/limit defaults, and introduces matchingci-operatorconfiguration + generated presubmit job YAMLs underci-operator/config/...andci-operator/jobs/.... This restores merge gating after the previously merged brokenoadp-1.4build.Updates Tide configuration (
core-services/prow/02_config/migtools/kopia/_prowconfig.yaml) to includeoadp-1.3inincludedBranches.Removes stale Kopia
rebasebotperiodic CI configurations and generated jobs foroadp-1.5andoadp-dev(deleted__periodicsinputs underci-operator/config/...and*-periodics.yamloutputs underci-operator/jobs/...).