Explicitly set -mod flag to mod in OTE build: release-4.14#293
Conversation
This is a continuation of work completed in openshift#275 and openshift#282. A separate go module was added alongside `openstack-test` in order to deal with ginkgo version conflicts. The separate OTE module is purposely not vendored, because doing so would introduce duplicate files and bloat the size of the git objects. `rhel-9-release-golang-1.23-openshift-4.16` forces vendoring through the GOFLAGS env var. So, to accomplish building the OTE binary without vendoring, an explicity command line option is required. Signed-off-by: Dan Childers <dchilder@redhat.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/assign @dlaw4608 |
|
/verified by @danchild |
openshift-ci-robot
added
the
verified
|
@danchild: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danchild: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/assign @gryf |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlaw4608, gryf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit e6ce37b
into
openshift:release-4.14
4 participants
This is a continuation of work completed in #275 and #282.
A separate go module was added alongside
openstack-testinorder to deal with ginkgo version conflicts. The separate
OTE module is purposely not vendored, because doing so
would introduce duplicate files and bloat the size of the
git objects.
rhel-9-release-golang-1.23-openshift-4.16forces vendoringthrough the GOFLAGS env var. So, to accomplish building the
OTE binary without vendoring, an explicity command line option
is required.