OSDOCS-17034: two node OCP CQA - #115222
Conversation
|
@skopacz1: This pull request references OSDOCS-17034 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -1,19 +1,21 @@ | |||
| :_mod-docs-content-type: ASSEMBLY | |||
| [id="about-two-node-arbiter-installation"] | |||
| = Two-Node with Arbiter | |||
There was a problem hiding this comment.
I don't know anything about Arbiter, so forgive my ignorance. Should it be capitalized here? Looks like it's lowercase in the body text.
There was a problem hiding this comment.
Genuinely unsure of this myself, I think I will just leave it as is and save it for the quality pass of CQAs later
| = Minimum resource requirements for installing a two-node OpenShift cluster with fencing | ||
|
|
||
| [role="_abstract"] | ||
| Each created cluster must meet minimum requirements so that the cluster runs as expected. |
There was a problem hiding this comment.
| Each created cluster must meet minimum requirements so that the cluster runs as expected. | |
| Each cluster must meet minimum requirements so that the cluster runs as expected. |
Just a nit. If there's a good reason to include the "created", feel free to ignore me.
| @@ -5,7 +5,7 @@ | |||
There was a problem hiding this comment.
Should this be a REFERENCE?
There was a problem hiding this comment.
Yeah I can see the case for that, I will change it here
There was a problem hiding this comment.
Should "none" be none? I know this isn't part of your proposed changes here, but I saw this in the preview, and it caught my attention.
There was a problem hiding this comment.
Yes that should probably be in backticks, good catch!
| ---- | ||
|
|
||
| * `platform.baremetal.apiVIPs` and `ingressVIPs`: Specifies virtual IPs for the API and Ingress endpoints. Required for bare-metal platform; not applicable for none. | ||
| * `platform.baremetal.apiVIPs` and `ingressVIPs`: Specifies virtual IPs for the API and Ingress endpoints. Required for bare-metal platform; not applicable for `none`. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'bare metal' rather than 'bare-metal'. For more information, see RedHat.TermsErrors.
|
@skopacz1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.22 |
|
@skopacz1: #115222 failed to apply on top of branch "enterprise-4.20": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: #115222 failed to apply on top of branch "enterprise-4.21": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: new pull request created: #115972 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.21 |
|
@skopacz1: new pull request created: #115977 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@skopacz1: #115222 failed to apply on top of branch "enterprise-4.21": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OSDOCS-17034
Version(s): 4.20+
CQA for two node cluster install docs.
QE review: not required IMO but let me know if you see anything that makes you disagree.
Previews: