OSDOCS-17043_2_a: CQA Azure machine set assembly and core modules by brendan-daly-red-hat · Pull Request #114616 · openshift/openshift-docs

brendan-daly-red-hat · 2026-07-06T08:28:00Z

Versions:
4.20+

Issue:
https://redhat.atlassian.net/browse/OSDOCS-17043

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

ocpdocs-previewbot · 2026-07-06T08:38:12Z

🤖 Tue Jul 21 13:21:31 - Prow CI generated the docs preview:

https://114616--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-supported-features-azure.html
https://114616--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating-infrastructure-machinesets.html
https://114616--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-azure.html
https://114616--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/creating_machinesets/creating-machineset-azure-stack-hub.html

brendan-daly-red-hat · 2026-07-17T16:00:38Z

/label merge-review-needed

jeana-redhat

A couple small items to address here, overall good!

/remove-label merge-review-in-progress
/remove-label merge-review-needed

jeana-redhat · 2026-07-20T16:46:27Z

 .Additional resources

-* link:https://docs.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks[Ephemeral OS disks for {azure-short} VMs ({azure-full} documentation)]
+* link:https://docs.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks[Ephemeral OS disks for {azure-first} VMs ({azure-short} documentation)]


This should be reverted (the linked article is "Ephemeral OS disks for Azure VMs" so {azure-short} is correct)

Suggested change

* link:https://docs.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks[Ephemeral OS disks for {azure-first} VMs ({azure-short} documentation)]

* link:https://docs.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks[Ephemeral OS disks for {azure-short} VMs ({azure-full} documentation)]

jeana-redhat · 2026-07-20T16:53:13Z

+* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#create-an-azure-key-vault-instance[Create an {azure-short} Key Vault instance ({azure-short} documentation)]
+* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#create-an-instance-of-a-diskencryptionset[Create an instance of a disk encryption set ({azure-short} documentation)]
+* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#grant-the-diskencryptionset-access-to-key-vault[Grant the disk encryption set access to key vault ({azure-short} documentation)]


Revert these. SSG states:

Write prerequisites as checks that are true or that the user must have completed before they begin a procedure. They can be actions that the user, another person, or piece of technology has completed. Prerequisites can also include items that the user must have ready before beginning the procedure.

and

Avoid using imperative formations.

Suggested change

* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#create-an-azure-key-vault-instance[Create an {azure-short} Key Vault instance ({azure-short} documentation)]

* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#create-an-instance-of-a-diskencryptionset[Create an instance of a disk encryption set ({azure-short} documentation)]

* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#grant-the-diskencryptionset-access-to-key-vault[Grant the disk encryption set access to key vault ({azure-short} documentation)]

* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#create-an-azure-key-vault-instance[You created an {azure-short} Key Vault instance ({azure-short} documentation)]

* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#create-an-instance-of-a-diskencryptionset[You created an instance of a disk encryption set ({azure-short} documentation)]

* link:https://docs.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys#grant-the-diskencryptionset-access-to-key-vault[You granted the disk encryption set access to key vault ({azure-short} documentation)]

jeana-redhat · 2026-07-20T16:55:03Z

 where:

-`<infrastructure_id>`:: Specifies the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. If you have the OpenShift CLI installed, you can obtain the infrastructure ID by running the following command:
+`<infrastructure_id>`:: Specifies the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. If you have the {product-title} CLI installed, you can obtain the infrastructure ID by running the following command:


It is actually "the OpenShift CLI" - if you want to avoid the name in text you can use the oc attribute here

Suggested change

`<infrastructure_id>`:: Specifies the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. If you have the {product-title} CLI installed, you can obtain the infrastructure ID by running the following command:

`<infrastructure_id>`:: Specifies the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. If you have the {oc-first} installed, you can obtain the infrastructure ID by running the following command:

jeana-redhat · 2026-07-20T16:55:50Z

 [NOTE]
 ====
-The value of the `spec.template.spec.providerSpec.value.zone` parameter specifies the zone within your region to place machines on. Ensure that your region supports the zone that you specify. If your region supports availability zones, you must specify the zone. Specifying the zone avoids volume node affinity failure when a pod requires a persistent volume attachment. To do this, you can create a compute machine set for each zone in the same region.
+The value of the `spec.template.spec.providerSpec.value.zone` parameter specifies the zone within your region to place machines on. If your region supports availability zones, you must specify the zone.


Why remove the statement "Ensure that your region supports the zone that you specify."?

openshift-ci · 2026-07-20T16:57:14Z

@jeana-redhat: Those labels are not set on the issue: merge-review-in-progress

Details

In response to this:

A couple small items to address here, overall good!

/remove-label merge-review-in-progress
/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci · 2026-07-21T13:23:53Z

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

brendan-daly-red-hat · 2026-07-21T14:32:24Z

/cherrypick enterprise-4.20

brendan-daly-red-hat · 2026-07-21T14:32:33Z

/cherrypick enterprise-4.21

brendan-daly-red-hat · 2026-07-21T14:32:38Z

/cherrypick enterprise-4.22

openshift-cherrypick-robot · 2026-07-21T14:33:16Z

@brendan-daly-red-hat: new pull request created: #115937

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-21T14:33:22Z

@brendan-daly-red-hat: new pull request created: #115938

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-21T14:33:27Z

@brendan-daly-red-hat: new pull request created: #115939

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

brendan-daly-red-hat · 2026-07-21T14:37:50Z

/cherry-pick enterprise-5.0

openshift-cherrypick-robot · 2026-07-21T14:38:42Z

@brendan-daly-red-hat: new pull request created: #115942

Details

In response to this:

/cherry-pick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 6, 2026

brendan-daly-red-hat force-pushed the OSDOCS-17043_2_a branch from 27684ad to 130ec70 Compare July 6, 2026 08:29

ocpdocs-vale-bot reviewed Jul 6, 2026

View reviewed changes

Comment thread modules/machineset-yaml-azure.adoc

brendan-daly-red-hat force-pushed the OSDOCS-17043_2_a branch 2 times, most recently from 242b2be to 8bfdd95 Compare July 17, 2026 15:47

brendan-daly-red-hat added this to the Continuous Release milestone Jul 17, 2026

brendan-daly-red-hat added branch/enterprise-4.20 branch/enterprise-4.22 branch/enterprise-5.0 branch/enterprise-4.21 labels Jul 17, 2026

openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 17, 2026

jeana-redhat reviewed Jul 20, 2026

View reviewed changes

openshift-ci Bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 20, 2026

brendan-daly-red-hat force-pushed the OSDOCS-17043_2_a branch from 8bfdd95 to 95081f0 Compare July 21, 2026 13:02

1

e8b2c36

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

brendan-daly-red-hat force-pushed the OSDOCS-17043_2_a branch from 95081f0 to e8b2c36 Compare July 21, 2026 13:13

openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2026

brendan-daly-red-hat merged commit 552fc30 into openshift:main Jul 21, 2026
2 checks passed

openshift-cherrypick-robot mentioned this pull request Jul 21, 2026

[enterprise-4.20] OSDOCS-17043_2_a: CQA Azure machine set assembly and core modules #115937

Merged

openshift-cherrypick-robot mentioned this pull request Jul 21, 2026

[enterprise-4.21] OSDOCS-17043_2_a: CQA Azure machine set assembly and core modules #115938

Merged

openshift-cherrypick-robot mentioned this pull request Jul 21, 2026

[enterprise-4.22] OSDOCS-17043_2_a: CQA Azure machine set assembly and core modules #115939

Merged

openshift-cherrypick-robot mentioned this pull request Jul 21, 2026

[enterprise-5.0] OSDOCS-17043_2_a: CQA Azure machine set assembly and core modules #115942

Merged

	* link:https://docs.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks[Ephemeral OS disks for {azure-first} VMs ({azure-short} documentation)]
	* link:https://docs.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks[Ephemeral OS disks for {azure-short} VMs ({azure-full} documentation)]

	`<infrastructure_id>`:: Specifies the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. If you have the {product-title} CLI installed, you can obtain the infrastructure ID by running the following command:
	`<infrastructure_id>`:: Specifies the infrastructure ID that is based on the cluster ID that you set when you provisioned the cluster. If you have the {oc-first} installed, you can obtain the infrastructure ID by running the following command:

Uh oh!

Conversation

brendan-daly-red-hat commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

brendan-daly-red-hat commented Jul 17, 2026

Uh oh!

jeana-redhat left a comment

Choose a reason for hiding this comment

Uh oh!

jeana-redhat Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

jeana-redhat Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

jeana-redhat Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

jeana-redhat Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 20, 2026

Uh oh!

openshift-ci Bot commented Jul 21, 2026

Uh oh!

Uh oh!

brendan-daly-red-hat commented Jul 21, 2026

Uh oh!

brendan-daly-red-hat commented Jul 21, 2026

Uh oh!

brendan-daly-red-hat commented Jul 21, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 21, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 21, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 21, 2026

Uh oh!

brendan-daly-red-hat commented Jul 21, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brendan-daly-red-hat commented Jul 6, 2026 •

edited

Loading

ocpdocs-previewbot commented Jul 6, 2026 •

edited

Loading