Revert "OCPBUGS-85429: hack/update-openapi-spec: prefer REGISTRY_AUTH_FILE over cluster profile pull secret"

[jubittajohn]

Reverts #669

Summary by CodeRabbit

• Bug Fixes
  • Registry authentication now prioritizes the cluster profile pull secret.
  • Falls back to REGISTRY_AUTH_FILE only when the cluster profile secret is unavailable.

[openshift-ci-robot]

@jubittajohn: This pull request references Jira Issue OCPBUGS-85429, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #669

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 818a0b0c-a78f-41b1-9c46-e3ab85211728

📥 Commits

Reviewing files that changed from the base of the PR and between 58298ec and eabeb97.

📒 Files selected for processing (1)

• hack/update-openapi-spec.sh

---

Walkthrough

The OpenAPI update script now checks the cluster profile pull secret before REGISTRY_AUTH_FILE when selecting registry credentials.

Changes

Registry authentication selection

Layer / File(s)	Summary
Update registry credential resolution hack/update-openapi-spec.sh	The script uses ${CLUSTER_PROFILE_DIR}/pull-secret when available. It falls back to ${REGISTRY_AUTH_FILE} and updates the related log messages and --registry-config option.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

• openshift/openshift-apiserver#669: Both PRs modify registry credential priority in hack/update-openapi-spec.sh.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies that the pull request reverts the change to registry authentication precedence.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only hack/update-openapi-spec.sh; the diff adds no Ginkgo test titles or dynamic test-name content.
Test Structure And Quality	✅ Passed	The patch changes only hack/update-openapi-spec.sh and adds no Ginkgo test code, so the listed test-quality requirements do not apply.
Microshift Test Compatibility	✅ Passed	The pull request changes only registry authentication order in hack/update-openapi-spec.sh and adds no Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only registry-authentication ordering in hack/update-openapi-spec.sh; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request modifies only registry authentication selection in hack/update-openapi-spec.sh and adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only hack/update-openapi-spec.sh; no OTE entrypoint or suite code changes. The added echo is shell-script status output, not OTE binary stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only registry authentication ordering in hack/update-openapi-spec.sh and adds no Ginkgo e2e tests or test networking assumptions.
No-Weak-Crypto	✅ Passed	The revert changes only registry pull-secret selection in hack/update-openapi-spec.sh; no weak algorithms, custom crypto, or secret comparisons appear in the added lines.
Container-Privileges	✅ Passed	The PR changes only hack/update-openapi-spec.sh; the diff contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation declarations.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only reorders authentication selection. Logs contain pull-secret file paths, not password, token, API-key, PII, session-ID, or customer data contents.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.