Backport cli download 1.3

[NicholasYancey]

Why the changes were made

OADP 1.6 added Console CLI download support in #1997: the operator deploys an oadp-cli download server and registers a ConsoleCLIDownload so users can install the CLI from Help → Command line tools in the OpenShift Console.

This PR backports the Console CLI download flow to oadp-1.3, with 1.3-specific adjustments:

• RELATED_IMAGE_CONSOLE_CLI_DOWNLOAD points at quay.io/konveyor/oadp-cli-binaries:oadp-1.3.
• OADP-7868: skip CLI download setup when the ConsoleCLIDownload CRD is not installed (e.g. clusters without Console capability).
• Adapted from internal/controller/ package path (1.5/1.6) to controllers/ for 1.3 compatibility.
• Removed DiscoveryClient() from timeoutFactory — not part of the Velero 1.12 Factory interface used in 1.3.
• VMDP / file-restore download from later 1.6 commits is not included — CLI download only.

How to test the changes made

git checkout backport-cli-download-1.3
make test

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d7eb9556-66f8-4460-9be2-30cf26a95555

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 3.09598% with 313 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.46%. Comparing base (059bc65) to head (e7b6cd9).
⚠️ Report is 2 commits behind head on oadp-1.3.

⚠️ Current head e7b6cd9 differs from pull request most recent head 1e630af

Please upload reports for the commit 1e630af to get more accurate results.

Files with missing lines	Patch %	Lines
controllers/cli_download_controller.go	0.00%	294 Missing ⚠️
main.go	0.00%	18 Missing ⚠️
controllers/console.go	90.90%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           oadp-1.3    #2299      +/-   ##
============================================
- Coverage     31.36%   29.46%   -1.90%     
============================================
  Files            28       30       +2     
  Lines          4489     4812     +323     
============================================
+ Hits           1408     1418      +10     
- Misses         2915     3228     +313     
  Partials        166      166              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kaovilai]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai, NicholasYancey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Joeavaikath,kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@NicholasYancey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.