Skip to content

Added iperf3#189

Open
jforce wants to merge 2 commits into
openshift:mainfrom
jforce:main
Open

Added iperf3#189
jforce wants to merge 2 commits into
openshift:mainfrom
jforce:main

Conversation

@jforce

@jforce jforce commented Jul 16, 2026

Copy link
Copy Markdown

Adding the iperf3 to the image for testing/troubleshooting network performance

Summary by CodeRabbit

  • Chores
    • Added iperf3 to the container environment, enabling network performance testing tools in deployments.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jforce, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 917679f9-16d8-4853-b8f8-3f8e93aa6b70

📥 Commits

Reviewing files that changed from the base of the PR and between 99f620d and 4e4a1ed.

📒 Files selected for processing (1)
  • Dockerfile

Walkthrough

The Dockerfile’s base image package list now includes iperf3 in the packages installed through yum.

Changes

Base image packages

Layer / File(s) Summary
Add iperf3 package
Dockerfile
Adds iperf3 to the INSTALL_PKGS package list used by yum.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: adding iperf3 to the image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only Dockerfile changed; no Ginkgo tests or titles were added or modified, so the stable-name check is not applicable.
Test Structure And Quality ✅ Passed Not applicable: this PR only adds iperf3 in Dockerfile; no Ginkgo test code or test structure changed.
Microshift Test Compatibility ✅ Passed PR only adds iperf3 to Dockerfile; no Ginkgo/e2e tests or OpenShift API usage were added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only Dockerfile changed; no new Ginkgo e2e tests or node-topology-sensitive code was added, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only the Dockerfile package list changed; no manifests, controllers, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only updates Dockerfile to add iperf3; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only Dockerfile changed to add iperf3; no Ginkgo/e2e tests were added or modified, so this IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed The PR only adds iperf3 to Dockerfile package installs; no weak ciphers, custom crypto, or secret comparisons are introduced.
Container-Privileges ✅ Passed Diff only adds iperf3 to Dockerfile’s package list; no privileged, hostPID/Network/IPC, capabilities, or securityContext settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only updates Dockerfile package installation to add iperf3; no logging code or sensitive-data output paths were changed.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jforce
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi @jforce. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Line 21: Update the INSTALL_PKGS package list by moving iperf3 above iproute,
preserving the existing alphabetized ordering.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a139a912-2946-4b35-a62a-61f5190f4019

📥 Commits

Reviewing files that changed from the base of the PR and between 0b53ac3 and 99f620d.

📒 Files selected for processing (1)
  • Dockerfile

Comment thread Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant