Skip to content

[ROSAENG-60411] Fixing numeric UID in DockerFile and Boilerplate Update#299

Open
TheUndeadKing wants to merge 3 commits into
openshift:mainfrom
TheUndeadKing:ROSAENG-60411
Open

[ROSAENG-60411] Fixing numeric UID in DockerFile and Boilerplate Update#299
TheUndeadKing wants to merge 3 commits into
openshift:mainfrom
TheUndeadKing:ROSAENG-60411

Conversation

@TheUndeadKing

@TheUndeadKing TheUndeadKing commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What is being added?

Fix
Use numeric UID 1001 (nobody, which exists on UBI minimal) instead of the string nonroot.
Boilerplate update

Checklist before requesting review

  • I have tested this locally
  • I have tested new image and tested in a cluster
  • I have included unit tests
  • I have updated any corresponding documentation

Steps To Manually Test

Please provide us steps to reproduce the scenarios needed to test this. If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.

  1. Start the operator
  2. Run the thing
  3. Observe X in the spec for the thing
  4. Clean up the thing

Ref OSD-0000

Summary by CodeRabbit

  • Chores
    • Updated build and test environment references to newer image versions.
    • Adjusted repository ownership and review settings, including updated approver assignments and alias mappings.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TheUndeadKing
Once this PR has been reviewed and has the lgtm label, please assign smarthall for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Walkthrough

This PR updates ownership configuration files (OWNERS, OWNERS_ALIASES, .tekton/OWNERS) to replace srep-based team groups with rosa-staff-engineers and related aliases, and updates build-related image references in .ci-operator.yaml and test/e2e/Dockerfile.

Changes

Ownership realignment

Layer / File(s) Summary
Approver and alias group updates
OWNERS, OWNERS_ALIASES, .tekton/OWNERS
Replaces srep-functional-leads, srep-team-leads, srep-infra-cicd, sre-group-leads, and srep-architects with rosa-staff-engineers, rosa-managers, and hp-architects; removes srep-functional-team-security entirely and one user from srep-functional-team-hulk; removes reviewers/approvers from .tekton/OWNERS.

Build and image references

Layer / File(s) Summary
Image version bumps
.ci-operator.yaml, test/e2e/Dockerfile
Updates build_root_image tag from image-v8.3.6 to image-v8.4.1 and switches the e2e builder base image to a newer OpenShift release Go toolchain image.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes CI/OWNERS/Dockerfile; no Ginkgo test titles were added or edited, so no unstable names are introduced.
Test Structure And Quality ✅ Passed PASS: This PR only changes OWNERS, boilerplate, and Dockerfile metadata; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e test specs were added; the PR only updates boilerplate/build config and a Dockerfile, so MicroShift API compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the diff only changes config, OWNERS, boilerplate, and a Dockerfile.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: No deployment manifests or controllers were changed, and the patch contains no nodeSelector, affinity, toleration, PDB, or topology logic.
Ote Binary Stdout Contract ✅ Passed PR only changes config, OWNERS, boilerplate scripts, and Dockerfiles; no Go entrypoint code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes Dockerfile/OWNERS/CI config, with no IPv4 or external-connectivity assumptions in changed test code.
No-Weak-Crypto ✅ Passed Touched files only change CI/OWNERS/Dockerfile settings; repo and patch search found no weak-crypto, custom crypto, or secret-compare code.
Container-Privileges ✅ Passed No changed manifest adds privileged flags, host namespaces, allowPrivilegeEscalation, or root execution; Dockerfile runtime user is 1001.
No-Sensitive-Data-In-Logs ✅ Passed Touched files are OWNERS/config/Dockerfile only; no logging statements or sensitive literals appear in them, so the PR doesn't add sensitive data to logs.
Title check ✅ Passed The title matches the main stated fix and boilerplate update, though it does not reflect all ownership and CI changes.
Description check ✅ Passed The description follows the required template and includes the change summary, checklist, manual test steps, and ref line.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.60%. Comparing base (4394d69) to head (ab8bcc0).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files           5        5           
  Lines         244      244           
=======================================
  Hits          143      143           
  Misses         87       87           
  Partials       14       14           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheUndeadKing

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2026
@TheUndeadKing

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2026
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@TheUndeadKing: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants