OCPBUGS-64847: kubelet: don't use non-admitted pods in calculation - #2667
Open
haircommander wants to merge 2 commits into
Open
OCPBUGS-64847: kubelet: don't use non-admitted pods in calculation#2667haircommander wants to merge 2 commits into
haircommander wants to merge 2 commits into
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Member
Author
|
/payload-aggregate periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance 10 |
|
Important Review skippedToo many files! This PR contains 2742 files, which is 2442 over the limit of 300. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (258)
📒 Files selected for processing (2742)
You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds ChangesPod allocation state filtering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
|
|
@haircommander: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
could not create PullRequestPayloadQualificationRun: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Please contact an administrator to resolve this issue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/kubelet/allocation/allocation_manager.go`:
- Around line 763-770: The allocatedPods slice is created with length
len(activePods) causing leading nil entries; change its allocation in
allocation_manager.go to use zero length and capacity len(activePods) (e.g.,
make([]*v1.Pod, 0, len(activePods))) so that appending allocatedPod from
m.UpdatePodFromAllocation(pod) produces a compact slice without nils; ensure the
loop using m.hasPodAllocatedResources and calling UpdatePodFromAllocation
continues to append to allocatedPods so callers like canAdmitPod can safely
access p.UID.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 06c6f732-792e-49ce-a11f-7e67b57d2902
📒 Files selected for processing (1)
pkg/kubelet/allocation/allocation_manager.go
haircommander
force-pushed
the
fix-rejected-pod-3-openshift
branch
from
May 13, 2026 20:31
dad1533 to
921b35e
Compare
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Member
Author
|
/payload-aggregate periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance 10 |
|
@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/38bcb890-4f0c-11f1-8489-0586b273e428-0 |
haircommander
force-pushed
the
fix-rejected-pod-3-openshift
branch
from
May 14, 2026 15:58
921b35e to
3cb4618
Compare
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
Member
Author
|
/payload-aggregate periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance 10 |
|
@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a43c4e10-4fb0-11f1-9de7-4de01fd38918-0 |
Member
Author
|
/retitle OCPBUGS-64847: kubelet: don't use non-admitted pods in calculation |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@haircommander: This pull request references Jira Issue OCPBUGS-64847, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bgudi@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Member
Author
|
/test k8s-e2e-conformance-aws |
Member
Author
|
unit test and some debugging assisted by claude 4.5 |
Member
Author
|
/retest |
Member
Author
|
/test e2e-aws-ovn-serial-1of2 |
|
@haircommander: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9d981ab0-52dc-11f1-8c6e-8c7ce2f94f5f-0 |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-upgrade-ovn-ipv6 |
|
@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b68585b0-7e85-11f1-9629-f56f08feeee4-0 |
haircommander
force-pushed
the
fix-rejected-pod-3-openshift
branch
from
July 13, 2026 17:58
3cb4618 to
eaba0f6
Compare
openshift-ci
Bot
added
the
needs-rebase
…pods Exclude non-admitted pods from allocation capacity calculations. Also skip non-allocated pods in HandlePodUpdates and HandlePodReconcile Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
fix-rejected-pod-3-openshift
branch
from
July 31, 2026 18:14
4691db6 to
6795fc4
Compare
openshift-ci-robot
removed
the
verified
openshift-ci-robot
added
backports/unvalidated-commits
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
Member
Author
|
/verified later @haircommander |
openshift-ci
Bot
removed
the
needs-rebase
openshift-ci-robot
added
verified-later
verified
|
@haircommander: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
fix-rejected-pod-3-openshift
branch
from
August 3, 2026 14:05
6795fc4 to
fad1904
Compare
openshift-ci-robot
removed
verified
|
@haircommander: the contents of this pull request could not be automatically validated. The following commits are valid:
The following commits could not be validated and must be approved by a top-level approver:
Comment |
Member
Author
|
/retest |
Member
Author
|
/verified later @haircommander |
openshift-ci-robot
added
verified-later
verified
|
@haircommander: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, haircommander, harche The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Summary by CodeRabbit
Refactor
Tests