Skip to content

SRVOCF-1040: Add setup guide to functions list - #143

Open
Cragsmann wants to merge 2 commits into
openshift:masterfrom
Cragsmann:SRVOCF-1040-add-setup-guide-secret-and-just-env-vars-for-function-workflow
Open

SRVOCF-1040: Add setup guide to functions list#143
Cragsmann wants to merge 2 commits into
openshift:masterfrom
Cragsmann:SRVOCF-1040-add-setup-guide-secret-and-just-env-vars-for-function-workflow

Conversation

@Cragsmann

@Cragsmann Cragsmann commented Aug 18, 2026

Copy link
Copy Markdown

Summary

  • 🎁 Add a "View setup guide." link in the functions list description that opens a modal walking users through setup: connecting GitHub with a PAT, creating a namespace and a secret for credentials, creating a function (with plain or secret-backed environment variables), and editing and redeploying it.
  • 🧪 Add unit tests for the SetupGuide component and its placement in the functions list page.
  • 🔧 Fix the ESLint parser configuration (set tsconfigRootDir, ignore .claude/) so lint runs cleanly regardless of local worktree layout.
image image

Fixes SRVOCF-1040

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

Add a "View setup guide" link in the functions list description
that opens a modal walking users through connecting GitHub,
creating a namespace and secret, creating a function, and
editing and redeploying it.

Also fix the ESLint parser configuration by setting
tsconfigRootDir and ignoring the .claude/ directory so lint
runs cleanly regardless of local worktree layout.

Issue SRVOCF-1040
Update the button name queries to expect "View setup guide."
so the tests match the label rendered by the component.

Issue SRVOCF-1040
@openshift-ci-robot

openshift-ci-robot commented Aug 18, 2026

Copy link
Copy Markdown

@Cragsmann: This pull request references SRVOCF-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • 🎁 Add a "View setup guide." link in the functions list description that opens a modal walking users through setup: connecting GitHub with a PAT, creating a namespace and a secret for credentials, creating a function (with plain or secret-backed environment variables), and editing and redeploying it.
  • 🧪 Add unit tests for the SetupGuide component and its placement in the functions list page.
  • 🔧 Fix the ESLint parser configuration (set tsconfigRootDir, ignore .claude/) so lint runs cleanly regardless of local worktree layout.

Fixes SRVOCF-1040

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 18, 2026
@openshift-ci
openshift-ci Bot requested review from matejvasek and twoGiants August 18, 2026 13:04
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cragsmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2026
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

@Cragsmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants