Skip to content

[release-4.22] OCPBUGS-98400: E2E: Add functional test cases checking GOMAXPROCS#1561

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1556-to-release-4.22
Jul 18, 2026
Merged

[release-4.22] OCPBUGS-98400: E2E: Add functional test cases checking GOMAXPROCS#1561
openshift-merge-bot[bot] merged 3 commits into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1556-to-release-4.22

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 10, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #1556

/assign mrniranjan

@mrniranjan
E2E: Add functional test cases checking GOMAXPROCS
3ab972c 
Following tests were added:
1. Verify GOMAXPROCS configuration is injected when Performance Profile
   is applied
2. Create a go-based container with below scenarios
   BestEffort - No Requests/Limits
   Burstable low - cpu:100m requests, no limits
   Burstable high - cpu:8 requests, no limits (2x overcommit)
   Guaranteed - cpu:1 request + limit
   Guaranteed with runtime class - cpu:1 request + limit
   Init + app container - cpu:100m on both, no limits
   Burstable with limit - cpu:2 request, cpu:4 limit

Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Add Matching memory resource for Gu Pod and minor cleanups
0a933b1 
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Fetch Runtimeclass from the profile applied
87341d0 
Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 10, 2026
Merged
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0d81e5c1-13a6-476b-b2b6-7b7a283219c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from ffromani and swatisehgal July 10, 2026 13:21
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-98399 has been cloned as Jira Issue OCPBUGS-98400. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-98400: E2E: Add functional test cases checking GOMAXPROCS

Details

In response to this:

This is an automated cherry-pick of #1556

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-98399: E2E: Add functional test cases checking GOMAXPROCS [release-4.22] OCPBUGS-98400: E2E: Add functional test cases checking GOMAXPROCS Jul 10, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98400, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-98399 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-98399 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1556

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MarSik

MarSik commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/retest-required

1 similar comment
@mrniranjan

mrniranjan commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@MarSik

MarSik commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed
/lgtm
/approve

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 15, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@mrniranjan

mrniranjan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/verified by @mrniranjan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@mrniranjan: This PR has been marked as verified by @mrniranjan.

Details

In response to this:

/verified by @mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

openshift-merge-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7ee68ae and 2 for PR HEAD 87341d0 in total

@mrniranjan

mrniranjan commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 169b483 into openshift:release-4.22 Jul 18, 2026
19 checks passed
@openshift-ci-robot

openshift-ci-robot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-98400
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-98400 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #1556

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

openshift-merge-robot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-07-18-214617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffromani ffromani Awaiting requested review from ffromani
@swatisehgal swatisehgal Awaiting requested review from swatisehgal
1 more reviewer
@MarSik MarSik MarSik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MarSik MarSik

@mrniranjan mrniranjan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @MarSik @mrniranjan @openshift-merge-robot