OCPBUGS-86033: Revert "NVIDIA-596: Enable dpu healthcheck "

[tssurya]

Reverts #2941

[openshift-ci-robot]

@tssurya: This pull request references NVIDIA-596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Reverts #2941

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR removes DPU node lease "health check" configuration (renew interval and duration) across bootstrap types, ConfigMap, ovn-kubernetes renderer logic, and OVN-Kubernetes templates/scripts, updates associated tests, adds optional proxy env vars to the managed ovnkube-node template, and reverts the Multus daemon-config cniVersion from 1.1.0 to 0.3.1.

Changes

DPU node lease removal

Layer / File(s)	Summary
Bootstrap type and ConfigMap contract pkg/bootstrap/types.go, hack/hardware-offload-config.yaml	Removes DpuNodeLeaseRenewInterval/DpuNodeLeaseDuration fields from OVNConfigBoostrapResult and the corresponding ConfigMap data keys.
Renderer and bootstrap logic pkg/network/ovn_kubernetes.go	Removes default lease constants, render data population, bootstrap default initialization, and ConfigMap override parsing/validation for lease values.
Templates and scripts bindata/network/ovn-kubernetes/common/008-script-lib.yaml, bindata/network/ovn-kubernetes/managed/ovnkube-node.yaml, bindata/network/ovn-kubernetes/self-hosted/ovnkube-node.yaml	Removes lease flag construction and conditional lease env vars; adds optional HTTP_PROXY, HTTPS_PROXY, NO_PROXY env vars to the managed template.
Test updates pkg/network/kube_proxy_test.go, pkg/network/ovn_kubernetes_dpu_host_test.go, pkg/network/ovn_kubernetes_test.go	Removes lease fields from test fixtures, deletes TestOVNKubernetesLeaseEnvVars, TestDpuLeaseConfig, and extractDaemonSetEnvVars helper.

Multus CNI version change

Layer / File(s)	Summary
CNI version revert bindata/network/multus/multus.yaml	Changes cniVersion in daemon-config.json from 1.1.0 to 0.3.1.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Related issues: None specified in provided information.

Related PRs: None specified in provided information.

Suggested labels: ovn-kubernetes, needs-rebase-check

Suggested reviewers: None specified in provided information.

🐰 A poem

A lease that once ticked, renewed and timed,
is snipped from scripts and structs, unrhymed.
No more DPU countdown to chase,
but proxies now get their env-var place.
And Multus turns back its version dial —
hop along, reviewer, it's just a short trial! 🐇

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No modified Ginkgo titles contain dynamic data; the only test names are static literals or fixed combinations of literals.
Test Structure And Quality	✅ Passed	PASS: The PR only removes obsolete DPU-lease test coverage and updates render fixtures; no new Ginkgo/cluster-interaction tests or timeout/cleanup issues were introduced.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the diffs only remove DPU-lease test code/config and add no new MicroShift-sensitive APIs or unchecked test blocks.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: No new Ginkgo e2e tests were added; the commit only removes a unit test and updates fixtures, so no new SNO-sensitive multi-node assumptions were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR only removes DPU lease config/envs and adds proxy envs; no new affinity, nodeSelector, spread, replica, or toleration constraints were introduced.
Ote Binary Stdout Contract	✅ Passed	Changed files only remove DPU lease config/tests; the only init() present just registers schemes, and no main/TestMain/BeforeSuite stdout writes appear.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the diff only removes DPU lease tests and updates unit-test fixtures, with no IPv4-only or external-connectivity assumptions introduced.
No-Weak-Crypto	✅ Passed	No added diff lines introduce MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons; changes only remove DPU lease plumbing.
Container-Privileges	✅ Passed	The commit only removes DPU lease config; no added or changed privileged, hostPID, hostNetwork, or allowPrivilegeEscalation settings appear in the diff.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only removes DPU lease fields/templates; no new log/print statements or sensitive-data emissions were added.
Title check	✅ Passed	The title accurately states that this PR reverts the DPU healthcheck change.
Description check	✅ Passed	The description is directly related and correctly says this PR reverts #2941.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[tssurya]

/retitle OCPBUGS-86033: Revert "NVIDIA-596: Enable dpu healthcheck "

[openshift-ci-robot]

@tssurya: This pull request references Jira Issue OCPBUGS-86033, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #2941

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tsorya]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsorya, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tssurya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@tssurya: This pull request references Jira Issue OCPBUGS-86033. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Reverts #2941

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.