Skip to content

Fix case with duplicate jakarta.xml.ws-api after migration, add transitive test case#1153

Draft
evie-lau wants to merge 4 commits into
openrewrite:mainfrom
evie-lau:duplicateWsApi
Draft

Fix case with duplicate jakarta.xml.ws-api after migration, add transitive test case#1153
evie-lau wants to merge 4 commits into
openrewrite:mainfrom
evie-lau:duplicateWsApi

Conversation

@evie-lau

@evie-lau evie-lau commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

If starting dependencies (pre-EE10) contained both jakarta.jws-api and jakarta.xml.ws-api, then the ReplaceJakartaJwsWithJakartaXmlWs would migrate and end up with two instances of jakarta.xml.ws-api

@evie-lau evie-lau self-assigned this Jun 26, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Jun 26, 2026
@evie-lau evie-lau changed the title Add failing test case where jakarta.xml.ws-api is duplicated Fix case with duplicate jakarta.xml.ws-api after migration Jun 26, 2026
@evie-lau evie-lau changed the title Fix case with duplicate jakarta.xml.ws-api after migration Fix case with duplicate jakarta.xml.ws-api after migration, add transitive test case Jun 26, 2026
@evie-lau evie-lau requested a review from timtebeek June 26, 2026 14:37
@evie-lau evie-lau marked this pull request as draft June 26, 2026 15:55
@timtebeek

Copy link
Copy Markdown
Member

Hi thanks! Instead of compensating for a duplication here, I propose we look to avoid the problem upstream if we can

@evie-lau

Copy link
Copy Markdown
Contributor Author

That sounds good, I can remove the recipe change here and keep the test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants