chore: pin GitHub Actions workflows to full commit SHAs#53
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 16 16
Lines 503 503
Branches 18 18
=======================================
Hits 468 468
Misses 24 24
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
farhan
approved these changes
May 19, 2026
farhan
approved these changes
May 19, 2026
feanil
approved these changes
May 30, 2026
feanil
pushed a commit
that referenced
this pull request
Jul 15, 2026
The dedicated SHA-pinning PR (#53) pinned every other action in this workflow (checkout, python-semantic-release, publish-action, upload-artifact, download-artifact, setup-node) but missed this one -- likely because @release/v1 looks like a branch name rather than the @vx version-tag pattern the other lines used, so it slipped past whatever tool/regex did that sweep. This isn't just a style nit: openedx/xblocks-core's real release just failed with "docker: manifest unknown" because @release/v1 resolved to a commit whose Docker image wasn't published on ghcr.io yet. Since this repo is the reference implementation every "modernize Python tooling" migration copies (openedx/public-engineering#506), the same unpinned ref propagates into every repo that follows this template. pypa/gh-action-pypi-publish's own README shows @release/v1 in its usage examples, but its own "pro tip" note recommends pinning to a tag or SHA rather than tracking a branch pointer -- there's no upstream guidance that this action is meant to be an exception to normal pinning practice. Co-authored-by: Irfan Ahmad <irfan.ahmad@A006-01919.local> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins all
uses:action refs to their full commit SHA with the version tag preserved as a comment. Part of org-wide SHA-pinning migration: openedx/.github#165