fix: add missing SiteConfig service override typings and definitions#281
Draft
vkumar-sonata wants to merge 1 commit into
Draft
fix: add missing SiteConfig service override typings and definitions#281vkumar-sonata wants to merge 1 commit into
vkumar-sonata wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns the SiteConfig TypeScript definitions with the existing runtime implementation.
The runtime initialize() function supports overriding the default service implementations through properties defined on SiteConfig:
However, these properties are currently not represented in the SiteConfig TypeScript definitions. As a result, consumers receive TypeScript compilation errors when attempting to register supported service overrides through site configuration.
Fix
Add the missing service override definitions to OptionalSiteConfig so that the TypeScript API matches the existing runtime behavior.
Validation
Context
Discovered during Datadog Browser Logs and RUM integration in frontend-site-learner-home.
LLM usage notice
Built with assistance from Copilot.