test(apiSpaces): a space admin can delete a space with no manager#3040
Merged
ScharfViktor merged 1 commit intoJun 29, 2026
Merged
Conversation
opencloud-eu#1877 reordered the api-test teardown to delete spaces before users, so the state where a project space's manager has been deleted is no longer exercised. This adds explicit coverage for it: the only manager of a project space is deleted, and a space admin can still list and delete (disable + purge) the space. Related: opencloud-eu#1878
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ -0.02% coverage variation (-1.00%) |
| Diff coverage | ✅ ∅ diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (ab7cf46) 82289 18957 23.04% Head commit (893aa05) 82289 (+0) 18940 (-17) 23.02% (-0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3040) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
ScharfViktor
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds one acceptance scenario to
apiSpaces/disableEnableDeleteSpaces.feature. After the only manager of a project space is deleted, a space admin must still be able to list the space and delete it (disable, then purge).All steps reuse existing step definitions. The change adds no step code.
Related Issue
Motivation and Context
#1877 reordered the api-test teardown to delete spaces before users. As a result, the suite no longer exercises the state where a project space's manager has been deleted, even incidentally, and no explicit scenario covers it.
Deleting a user who manages a project space is a normal operation. It happens on every user removal, including out-of-band removal via an external IdP. The space must stay manageable by a space admin afterwards. This scenario pins that behavior so a later change cannot regress it.
Note
The scenario exercises the read path for a space whose manager is gone. On a server without the reva read-path fixes, that path logs
could not read nodeanderror while indexing a space(the subject of #1878, addressed by opencloud-eu/reva#710 and opencloud-eu/reva#713). The scenario is green regardless: the space stays listable and deletable. The log noise is a server-side concern, not an API status.How Has This Been Tested?
behat acceptance, run against a stock
opencloud-rolling:7.2.0container on both storage drivers:Screenshots (if appropriate):
Types of changes
Checklist:
🤖 drafted with Claude Code, reviewed before submitting.