fix(search): use MustNot query for Deleted filter in bleve#3038
Open
flash7777 wants to merge 1 commit into
Open
fix(search): use MustNot query for Deleted filter in bleve#3038flash7777 wants to merge 1 commit into
flash7777 wants to merge 1 commit into
Conversation
BoolFieldQuery{Bool: false, Field: "Deleted"} does not match documents
where the Deleted field was never explicitly set. Bleve does not index
zero-value bools by default, so after an index rebuild (or on fresh
installations), all new documents lack an indexed Deleted field and are
excluded from every search query, resulting in 0 results.
Switch to a BooleanQuery with MustNot(Deleted==true), which correctly
includes all documents where Deleted is absent or false, and only
excludes documents explicitly marked as deleted.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The search service uses a
BoolFieldQuery{Bool: false, Field: "Deleted"}to exclude trashed documents from results. However, bleve does not index zero-value bools by default. This means documents whereDeletedwas never explicitly set (i.e., all non-trashed documents) lack this field in the index and are excluded from every query.Impact: After an index rebuild or on fresh installations, search returns 0 results for all queries.
Root cause
When a
Resourceis indexed withDeleted: false(Go zero value), bleve's default mapping does not store the bool field. The existingBoolFieldQuery{Bool: false}then finds no matching documents, causing the conjunction query to return empty results.Fix
Replace
BoolFieldQuery{Bool: false}with aBooleanQuery.MustNot(BoolFieldQuery{Bool: true}). This correctly:Deletedis absent (never set)Deletedis explicitlyfalseDeletedis explicitlytrueTest plan
Changes
services/search/pkg/bleve/backend.go: 1 file, +11/-5