feat(search): index ArbitraryMetadataUpdated events#3035
Open
flash7777 wants to merge 1 commit into
Open
Conversation
Subscribe to the new ArbitraryMetadataUpdated event from reva and trigger UpsertItem + IndexSpace debounce, matching the existing pattern for TagsAdded/TagsRemoved. Without this, custom metadata set via WebDAV PROPPATCH or the Graph Metadata API is invisible to search until the next full space re-index.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subscribe to the new
ArbitraryMetadataUpdatedevent and triggerUpsertItem+IndexSpacedebounce in the search service. This matches the existing pattern forTagsAdded/TagsRemoved.Motivation
Custom metadata set via WebDAV PROPPATCH or the Graph Metadata API was invisible to search until the next full space re-index, because
SetArbitraryMetadatadid not emit any event. This was the only write operation missing from the event pipeline.Depends on
ArbitraryMetadataUpdatedevent type and emits it from the events middleware interceptor. This PR will not build until reva#712 is merged and the reva dependency is updated.Changes
services/search/pkg/service/event/service.go: addevents.ArbitraryMetadataUpdated{}to subscribe list, add case to event handler (+4 lines)Test plan