Apply design-system composer to app chat UI#984
Conversation
|
Codex review: found issues before merge. Reviewed July 13, 2026, 7:47 PM ET / 23:47 UTC. Summary Reproducibility: not applicable. This PR proposes a user-facing redesign and a new persisted setting rather than repairing a reproducible current-main failure. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Land the design-system composer with explicitly approved control placement, genuine translations for every supported locale, and the existing accessibility and persisted-state behavior preserved. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a user-facing redesign and a new persisted setting rather than repairing a reproducible current-main failure. Is this the best way to solve the issue? Unclear: the composer implementation is coherent, but maintainers must confirm that moving both controls into Settings is the desired narrow and maintainable UX boundary. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 77c42440376e. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (4 earlier review cycles)
|
Rebase the final composer redesign onto current main, preserve the FunctionalUI picker fix, stabilize menu flyouts across rerenders, localize Chat settings, and retain current speaker and Send/Stop behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fef25ef9-fa78-442c-beb0-d0a6f9a8fb92
8434453 to
6220c85
Compare
Summary
Applies the native WinUI chat-composer redesign and Chat settings directly to current
main. The branch is independent of PR #962 and has been squash-rebased after PRs #990, #988, #986, and #991 landed.Composer redesign
ContentFlyoutwith model subtext and localized current-session accessibility state.ToggleMenuFlyoutItemrows.composerInputidentity, current-main speaker/read-aloud behavior, and the single Send/Stop action slot.Chat settings
SettingsData.ShowChatToolCallsandOpenClawChatRoot.SetToolCallsVisibleapplication.Rebase integration
ItemComboBoxprimitive while the redesigned composer uses declarative flyouts.ChannelGroupin its new focused owner file and widens its session projection with model/provider metadata.NativeElementescape hatches.Validation
Current head:
6220c85133723b5b4bebb2dfbab44b7ae4c90648.\build.ps1— passed; all five source projects built.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore— 2,787 passed, 31 skipped, 0 failed.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore— 1,717 passed, 0 failed.dotnet test .\tests\OpenClawTray.FunctionalUI.Tests\OpenClawTray.FunctionalUI.Tests.csproj --no-restore— 15 passed, 0 failed.dotnet test .\tests\OpenClaw.Tray.UITests\OpenClaw.Tray.UITests.csproj -r win-arm64 --no-restore --filter "FullyQualifiedName~SessionTitleBehaviorProofTests"— 1 passed, 0 failed.git diff --cached --check— passed before commit.Real behavior proof
ChatComposerInput, and verified the redesigned Session button announced and selected the original route keys for both sessions.SessionTitleBehaviorProofTestspassed on the rebased head.Visual references