setup_network.sh: fix pnp address check - #3720
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes plug’n’play IP address validation in setup_network.sh so correctly formatted IPv4 addresses (e.g., 192.168.193.251) are no longer rejected, addressing issue #3719.
Changes:
- Replaced the IPv4 validation regex with a Bash
[[ ... =~ ... ]]-compatible expression (removes unsupported PCRE-style non-capturing groups). - Ensures
setup_pnp_network()accepts valid PnP IPs from MQTT instead of falling back to the default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #3719