Deprecate TextMapGetter keys method#8531
Draft
arnabnandy7 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8531 +/- ##
=========================================
Coverage 90.94% 90.94%
- Complexity 10210 10211 +1
=========================================
Files 1013 1013
Lines 27175 27176 +1
Branches 3184 3184
=========================================
+ Hits 24714 24715 +1
Misses 1734 1734
Partials 727 727 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Added |
Author
@jack-berg I've converted it to a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates
TextMapGetter.keys()and gives it a default empty implementation soTextMapGettercan be used as a functional interface.This lets callers implement
TextMapGetterwith a lambda when onlyget()behavior is needed, while preserving existing carrier-key enumeration behavior for implementations that overridekeys().Changes
TextMapGetteras@FunctionalInterface.TextMapGetter.keys().keys()implementation returning an empty iterable.TextMapGetterimplementation.keys()usage in deprecated Jaeger and OT trace baggage extraction paths.opentelemetry-contextAPI diff.Testing
./gradlew :context:test --tests io.opentelemetry.context.propagation.TextMapGetterTest./gradlew :extensions:trace-propagators:compileJava./gradlew :context:jApiCmp./gradlew :context:spotlessApply :extensions:trace-propagators:spotlessApplygit diff --checkFixes #8470 and dependent on spec:5177