Move declarative config experimental types to internal package#8530
Merged
jack-berg merged 1 commit intoJun 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8530 +/- ##
============================================
- Coverage 90.94% 90.91% -0.03%
+ Complexity 10210 10207 -3
============================================
Files 1013 1013
Lines 27175 27175
Branches 3184 3184
============================================
- Hits 24714 24706 -8
- Misses 1734 1742 +8
Partials 727 727 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaydeluca
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8402.
Adjusts jsonschema2pojo generation logic to move experimental types (i.e. those with
Experimental*prefix) to the*.model.internal*package.This is a prereq to us stabilizing the APIs because experimental types are subject to breaking changes that violate our versioning policy.
Still TODO in a followup: some stable types reference experimental types. For example:
opentelemetry-java/sdk-extensions/declarative-config/src/main/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/model/ResourceModel.java
Lines 70 to 74 in 77eb68d
We need to figure out a way to hide these accessors from the API, since they too are subject to breaking changes.