Skip to content

Move declarative config experimental types to internal package#8530

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
jack-berg:declarative-config-experimental-models
Jun 25, 2026
Merged

Move declarative config experimental types to internal package#8530
jack-berg merged 1 commit into
open-telemetry:mainfrom
jack-berg:declarative-config-experimental-models

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Part of #8402.

Adjusts jsonschema2pojo generation logic to move experimental types (i.e. those with Experimental* prefix) to the *.model.internal* package.

This is a prereq to us stabilizing the APIs because experimental types are subject to breaking changes that violate our versioning policy.

Still TODO in a followup: some stable types reference experimental types. For example:

@JsonProperty("detection/development")
@Nullable
public ExperimentalResourceDetectionModel getDetectionDevelopment() {
return detectionDevelopment;
}

We need to figure out a way to hide these accessors from the API, since they too are subject to breaking changes.

@jack-berg jack-berg requested a review from a team as a code owner June 24, 2026 17:00
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (77eb68d) to head (25b2319).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8530      +/-   ##
============================================
- Coverage     90.94%   90.91%   -0.03%     
+ Complexity    10210    10207       -3     
============================================
  Files          1013     1013              
  Lines         27175    27175              
  Branches       3184     3184              
============================================
- Hits          24714    24706       -8     
- Misses         1734     1742       +8     
  Partials        727      727              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 104d56e into open-telemetry:main Jun 25, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants