Fix BatchLogRecordProcessor worker thread killed by non-runtime exception#8529
Open
EvgeniiR wants to merge 1 commit into
Open
Conversation
…tion Mirror of open-telemetry#4402 for BatchSpanProcessor: catch (Throwable) with ThrowableUtil.propagateIfFatal so a checked exception thrown by a LogRecordExporter (e.g. from Kotlin) no longer kills the worker thread and silently drops all subsequent logs.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8529 +/- ##
=============================================
+ Coverage 78.50% 90.93% +12.42%
- Complexity 8600 10208 +1608
=============================================
Files 1013 1013
Lines 29150 27176 -1974
Branches 3632 3184 -448
=============================================
+ Hits 22884 24712 +1828
+ Misses 5421 1738 -3683
+ Partials 845 726 -119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8528
This is essentially the same issue as #4348 . Issue was fixed for
BatchSpanProcessor, but still present inBatchLogRecordProcessor.This PR also fixes it for
BatchLogRecordProcessor