EnvironmentGetter and EnvironmentSetter empty name normalization#8481
Open
pellared wants to merge 2 commits into
Open
EnvironmentGetter and EnvironmentSetter empty name normalization#8481pellared wants to merge 2 commits into
pellared wants to merge 2 commits into
Conversation
Member
Author
|
PTAL @jack-berg |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8481 +/- ##
=========================================
Coverage 78.54% 78.54%
- Complexity 8473 8474 +1
=========================================
Files 1008 1008
Lines 28830 28832 +2
Branches 3570 3571 +1
=========================================
+ Hits 22644 22646 +2
Misses 5341 5341
Partials 845 845 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zeitlinger
approved these changes
Jun 19, 2026
Contributor
|
I believe this still needs the above-mentioned spec PR to be merged before we can merge this. |
jkwatson
requested changes
Jun 20, 2026
jkwatson
left a comment
jkwatson
left a comment
Contributor
There was a problem hiding this comment.
Just need to have the spec PR merged first, then good to go.
jack-berg
approved these changes
Jun 22, 2026
Member
Author
@jkwatson, @jack-berg, I unblocked this PR by merging the spec PR 😉 |
Member
Author
|
Side note: you can also read this conversation which is related to the However, I do not want to address this in this PR 😅 |
pellared
added a commit
to pellared/opentelemetry-specification
that referenced
this pull request
Jun 22, 2026
…try#5163) Issue discovered by @MrAlias in open-telemetry/opentelemetry-go-contrib#9112 (comment) Also see open-telemetry#5163 (comment) Prototypes: - open-telemetry/opentelemetry-go-contrib@0fedf62 - open-telemetry/opentelemetry-dotnet#7424 - open-telemetry/opentelemetry-swift-core#86 - open-telemetry/opentelemetry-python#5328 - open-telemetry/opentelemetry-js#6827 - open-telemetry/opentelemetry-java#8481 For values to be fully portable across POSIX-compliant systems and shell utilities, the standard dictates that environment variable names must consist solely of uppercase letters, digits, and underscores (_), and must not begin with a digit. While some individual implementations might tolerate unusual characters, an empty string lacks any valid characters entirely and cannot act as a recognizable identifier. I verified that on Ubuntu it is not possible to set a env var with an empty name. --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows open-telemetry/opentelemetry-specification#5163