[BUILD] Create the configuration_core library for programmatic config#4311
Open
dbarker wants to merge 5 commits into
Open
[BUILD] Create the configuration_core library for programmatic config#4311dbarker wants to merge 5 commits into
dbarker wants to merge 5 commits into
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4311 +/- ##
==========================================
+ Coverage 81.24% 81.25% +0.02%
==========================================
Files 446 446
Lines 18872 18872
==========================================
+ Hits 15330 15332 +2
+ Misses 3542 3540 -2
🚀 New features to boost your workflow:
|
dbarker
marked this pull request as ready for review
July 26, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #4134 and follow up from ##3655 (review)
This PR creates a new library (
configuration_core) to contain the SDK configuration components that do not require external dependencies. This library is built unconditionally with the SDK and available in thesdkCMake component. The YAML configuration component (and ryml dependency) remain with theconfigurationlibrary and publicly link to theconfiguration_corelibrary.Changes
opentelemetry-cpp::configuration_coreCMake target for all configuration components that don't require external dependenciesopentelemetry-cpp::configurationCMake target now just includes the ryml dependent components (ryml document, yaml parser).For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes