Skip to content

Remove file_http_server.h#4306

Merged
dbarker merged 2 commits into
open-telemetry:mainfrom
owent:remove_file_http_server
Jul 26, 2026
Merged

Remove file_http_server.h#4306
dbarker merged 2 commits into
open-telemetry:mainfrom
owent:remove_file_http_server

Conversation

@owent

@owent owent commented Jul 25, 2026

Copy link
Copy Markdown
Member

Fixes #4299

Changes

  • Remove file_http_server.h, it's not used for a long time.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.24%. Comparing base (29d7a75) to head (d6f339a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4306      +/-   ##
==========================================
- Coverage   81.25%   81.24%   -0.01%     
==========================================
  Files         446      446              
  Lines       18872    18872              
==========================================
- Hits        15332    15330       -2     
- Misses       3540     3542       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff
marcalff marked this pull request as ready for review July 25, 2026 20:53
@marcalff
marcalff requested a review from a team as a code owner July 25, 2026 20:53

@marcalff marcalff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is dead code.

@dbarker
dbarker merged commit aa60678 into open-telemetry:main Jul 26, 2026
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] file_http_server.h does not compile on Windows

3 participants