Skip to content

Change the default value of protection_window from 24h to implicit behavior 0s #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vlasdislav wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Change the default value of protection_window from 24h to implicit behavior 0s #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ behaviour of garbage collection performed during
| `trash_retention_days` | int | `7` | Number of days a file stays in `/trash` before being permanently removed. |
| `trash_move_workers` | int | `1` | Number of parallel workers used to move files to `/trash`. |
| `trash_delete_workers` | int | `1` | Number of parallel workers used to delete files from `/trash`. |
| `protection_window` | duration | `24h` | Minimum age a file must have, based on its storage `LastMod` timestamp, before it is eligible for garbage deletion. Accepts a duration string, e.g. `"1h"`, `"30m"`, `"24h"`. Set to `"0s"` to disable this extra protection window. |
| `protection_window` | duration | `0s` | Minimum age a file must have, based on its storage `LastMod` timestamp, before it is eligible for garbage deletion. Accepts a duration string, e.g. `"1h"`, `"30m"`, `"24h"`. Set to `"0s"` to disable this extra protection window. |

Regardless of the `protection_window` value, yproxy **always**
unconditionally skips any file whose `LastMod` timestamp is at or
Expand Down
2 changes: 1 addition & 1 deletion config/vacuum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const (
DefaultTrashRetentionDays = 7
DefaultTrashMoveWorkers = 1
DefaultTrashDeleteWorkers = 1
DefaultProtectionWindow = 24 * time.Hour
DefaultProtectionWindow = 0 * time.Second
)

type Vacuum struct {
Expand Down
Loading