fix(gha): flip merged release PR label to autorelease: tagged - #302
Merged
Conversation
release-please-config.json sets skip-github-release: true so the
release.yml stable job (not release-please) creates the tag/GitHub
Release. Release-please never sees that as "finalized" and leaves the
merged release PR labeled autorelease: pending forever, which makes it
permanently refuse to open the next release PR ("There are untagged,
merged release PRs outstanding - aborting").
Have the release_github job relabel the merged PR to
autorelease: tagged right after it creates the GitHub release, so
release-please's own bookkeeping matches reality.
so0k
commented
Jul 4, 2026
The label is a one-time, repo-wide fixture (already created), so attempting to create it on every release was unnecessary. Addressed feedback: https://github.com/open-constructs/cdk-terrain/pull/302/changes#r3522958993
so0k
added
ci/skip-examples
jsteinich
approved these changes
Jul 5, 2026
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please-config.jsonsetsskip-github-release: truesorelease.yml's stable job (not release-please) creates the tag/GitHub Release, avoiding a double-create race.autorelease: pendingtoautorelease: tagged.autorelease: pending("There are untagged, merged release PRs outstanding - aborting") — this silently blocked every release PR after v0.23.4 shipped.release_githubjob that relabels the merged PR right after the GitHub release is created, so release-please's bookkeeping matches reality going forward.PR #254 (v0.23.4) was manually relabeled
autorelease: taggedalready to unblock the standing PR immediately; this change prevents the same thing from recurring on every future release.One-off setup performed by hand (label didn't exist yet)
Test plan
actionlint .github/workflows/release.yml— no new findings (only pre-existing unrelated warnings)