Clarify model export and runtime ownership - #500
Merged
Conversation
Document that Mobius emits faithful artifacts without gating on downstream ORT GenAI capabilities. Strengthen cache, quantization, provider isolation, and optional runtime validation guidance while preserving direct GGUF defaults. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mobius’s internal Skills documentation to clarify that Mobius is responsible for faithful, graph-derived export metadata, while ORT GenAI / Foundry Local runtime acceptance is optional downstream evidence that must not gate artifact emission.
Changes:
- Refines the Definition-of-Done guidance to distinguish required metadata correctness from optional downstream runtime probes.
- Adds/adjusts diagnostic guidance for cached-decode failures and for validating standard-ONNX controls before attributing issues to Olive/runtime.
- Documents operational guidance around provider isolation for weight-only quantization workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.agents/skills/writing-tests/SKILL.md |
Adds guidance on reduced real-weight fixtures and cached-decode parity checks. |
.agents/skills/quality-checklist/SKILL.md |
Reframes checklist items around metadata correctness and optional downstream runtime probes. |
.agents/skills/ort-genai-config/SKILL.md |
Clarifies Mobius metadata ownership vs ORT GenAI runtime capability decisions. |
.agents/skills/onnx-export-quantization/SKILL.md |
Adds provider-isolation guidance and reframes ORT GenAI quantized smoke tests as optional. |
.agents/skills/multimodal-models/SKILL.md |
Aligns multimodal guidance with “emit faithful metadata; runtime is optional probe”. |
.agents/skills/diffusion-models/SKILL.md |
Aligns diffusion guidance to avoid runtime limitations becoming export gates. |
.agents/skills/adding-a-new-model/SKILL.md |
Updates the checklist to emphasize tested graph-derived metadata and optional downstream probes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Performance Comparison
|
Require direct ONNX Runtime validation for GGUF imports while keeping downstream GenAI and Foundry probes optional. Clarify reduced-fixture and metadata wording from review. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Move dual-head-dimension runtime configuration guidance into optional downstream evidence and state that omitted probes require no waiver or TODO. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
added a commit
that referenced
this pull request
Aug 15, 2026
Remove the seven cross-cutting skill updates from the Nemotron implementation branch now that they are published independently in PR #500. Retain Nemotron-specific MoE guidance and all implementation, test, example, and workflow changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
This was referenced Aug 15, 2026
justinchuby
commented
Aug 15, 2026
justinchuby
commented
Aug 15, 2026
justinchuby
commented
Aug 15, 2026
justinchuby
commented
Aug 15, 2026
justinchuby
commented
Aug 15, 2026
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Only the seven intended
SKILL.mdfiles are changed. Model code, tests, workflows, examples, and.agents/skills/moe-models/SKILL.mdare intentionally excluded.Validation
python -m pytest tests/yaml_schema_test.py -q --tb=short(246 passed)lintrunner -a --output onelinegit diff --check