Improve model integration skills from merged PRs - #482
Merged
Conversation
Capture recurring lessons from agent retrospectives and review history across recent model integrations. Tighten source/config fidelity, processor and runtime contracts, real GPU validation, graph optimization evidence, CI triage, and multi-agent rebase guidance while shortening duplicated multimodal dtype documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Performance Comparison
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the internal “skills” documentation under .agents/skills/ to capture integration lessons learned from recently merged model PRs, with an emphasis on tighter runtime/processor contracts, reproducible golden testing, and evidence-based CI/runtime validation practices.
Changes:
- Strengthen testing guidance around end-to-end ONNX stage wiring, exact/reproducible goldens, and cache/processor contract validation.
- Clarify component import patterns, canonical ONNX op preferences, and public-call compatibility expectations.
- Add sharper CI triage, runtime support verification, quantization caveats, and diffusion pipeline executability requirements.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .agents/skills/writing-tests/SKILL.md | Expands integration/golden test guidance (wiring, masks/defaults, processor contracts, reproducibility). |
| .agents/skills/reusable-components/SKILL.md | Clarifies intra-components import guidance and adds operator/compatibility best practices. |
| .agents/skills/quality-checklist/SKILL.md | Tightens definition-of-done checks (pinned revision propagation, dtype semantics, CI tool verification, CI triage). |
| .agents/skills/ort-genai-config/SKILL.md | Adds guidance for hybrid cache slot derivation and CUDA Graph capture scope/validation. |
| .agents/skills/onnx-export-quantization/SKILL.md | Notes Attention rewrite/schema mismatch pitfalls and validation expectations. |
| .agents/skills/multimodal-models/SKILL.md | Reframes processor-to-graph contract guidance; emphasizes real processor batches and mixed-media edge cases. |
| .agents/skills/multi-agent-coordination/SKILL.md | Refines multi-agent workflow guidance and branch strategy/CI triage recommendations. |
| .agents/skills/diffusion-models/SKILL.md | Adds an explicit “prove pipeline executability” requirement for diffusion exports/runtime claims. |
| .agents/skills/debugging-multimodal/SKILL.md | Updates encoder input dtype guidance to align with real processor float32 boundaries. |
| .agents/skills/adding-a-new-model/SKILL.md | Reinforces revision pinning, config-semantic fidelity, and compatibility traps checklist items. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sources
Direct agent retrospectives plus commit/review history for merged PRs #462-#465, #471-#473, and #475.
Validation
No runtime code is changed.