fix(client): restore Electron chat rooms navigation - #403
Closed
NWYLZW wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Experience Review
Before merge, make sure the PR body contains this completed checklist:
## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer `PASS` / `NOT APPLICABLE` 后才进入 mergeChecklist to confirm:
- Decide whether this PR produced reusable project experience.
- If experience should be captured, run
$post-task-experience-review. - Merge only after the independent reviewer reports
PASSorNOT APPLICABLEfor the Experience Review Result. - For workflow, permission, or release-rule documentation changes, also add this checked section to the PR body after an independent read-only conflict review:
## Policy Conflict Review
- [x] Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ui/./w/:workspaceIdin the browser URL.Changelog
changelog/1.0.0-rc.6/client.mdScreenshots
Behavior-only restoration of an existing native NavRail item; no new visual primitive, layout, or CSS. Independent packaged Electron validation confirmed exactly one
团队群聊entry in the compatibility/ui/workspace, native spacing/theme/selected state, and successful click-through to the existing room UI.Validation
pnpm exec vitest run --workspace vitest.workspace.ts --project node packages/plugins/channel-oneworks/__tests__/oneworks-channel-plugin.test.ts(4/4)pnpm --filter @oneworks/plugin-channel-oneworks typecheckgit diff --checkpnpm --filter @oneworks/plugin-channel-oneworks build:clientpnpm desktop:packagepnpm -C apps/desktop smoke:package/ui/, runtime roleworkspace, one visible Chat Rooms entry, route click-through and room UI render PASSReview Scope
Experience Review
$post-task-experience-review(本次稳定运行时角色约束已写入模块AGENTS.md并随精确差异独立复核)PASS/NOT APPLICABLE后才进入 mergeExperience Review Result: PASS — the reusable compatibility-path invariant is captured in the nearest module guidance and the exact documentation/code change passed independent review.
Policy Conflict Review
Not applicable; this PR does not change workflow, permission, or release-rule documentation.