Skip to content

fix(client): restore Electron chat rooms navigation - #403

Closed
NWYLZW wants to merge 1 commit into
mainfrom
codex/fix-electron-chat-rooms-nav
Closed

fix(client): restore Electron chat rooms navigation#403
NWYLZW wants to merge 1 commit into
mainfrom
codex/fix-electron-chat-rooms-nav

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore the existing Chat Rooms navigation entry in packaged Electron compatibility workspaces served at /ui/.
  • Use the plugin runtime endpoint role as the workspace authority instead of inferring ownership from /w/:workspaceId in the browser URL.
  • Keep manager and launcher runtimes excluded without adding Electron-specific branches or changing route, command, layout, or style ownership.

Changelog

  • Changelog path or "Not applicable": changelog/1.0.0-rc.6/client.md

Screenshots

Behavior-only restoration of an existing native NavRail item; no new visual primitive, layout, or CSS. Independent packaged Electron validation confirmed exactly one 团队群聊 entry in the compatibility /ui/ workspace, native spacing/theme/selected state, and successful click-through to the existing room UI.

Validation

  • pnpm exec vitest run --workspace vitest.workspace.ts --project node packages/plugins/channel-oneworks/__tests__/oneworks-channel-plugin.test.ts (4/4)
  • pnpm --filter @oneworks/plugin-channel-oneworks typecheck
  • Exact-path ESLint and dprint checks
  • git diff --check
  • pnpm --filter @oneworks/plugin-channel-oneworks build:client
  • pnpm desktop:package
  • pnpm -C apps/desktop smoke:package
  • Independent packaged Electron behavior and visual review: compatibility URL /ui/, runtime role workspace, one visible Chat Rooms entry, route click-through and room UI render PASS

Review Scope

  • Risk: low
  • Applicable profiles: Electron workspace plugin runtime; client plugin activation; behavior and visual consistency
  • Evidence: exact-diff local/global review PASS; independent real packaged Electron behavior/visual review PASS
  • Rule exceptions: none

Experience Review

  • 已判断是否需要沉淀经验
  • 如需要,已运行 $post-task-experience-review(本次稳定运行时角色约束已写入模块 AGENTS.md 并随精确差异独立复核)
  • reviewer PASS / NOT APPLICABLE 后才进入 merge

Experience Review Result: PASS — the reusable compatibility-path invariant is captured in the nearest module guidance and the exact documentation/code change passed independent review.

Policy Conflict Review

Not applicable; this PR does not change workflow, permission, or release-rule documentation.

@NWYLZW
NWYLZW requested a review from a team as a code owner August 21, 2026 04:16
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oneworks-dev Ready Ready Preview Aug 21, 2026 4:17am

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience Review

Before merge, make sure the PR body contains this completed checklist:

## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer `PASS` / `NOT APPLICABLE` 后才进入 merge

Checklist to confirm:

  • Decide whether this PR produced reusable project experience.
  • If experience should be captured, run $post-task-experience-review.
  • Merge only after the independent reviewer reports PASS or NOT APPLICABLE for the Experience Review Result.
  • For workflow, permission, or release-rule documentation changes, also add this checked section to the PR body after an independent read-only conflict review:
## Policy Conflict Review
- [x] Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant