types: add 'max' think level to match Go ThinkValue#702
Open
vaderollama wants to merge 1 commit into
Open
Conversation
The Go API's ThinkValue type accepts 'max' as a valid string level (in addition to 'low', 'medium', 'high'), but the Python client was missing it from all think annotations across _types.py and _client.py. This adds 'max' to every think parameter annotation consistently: - GenerateRequest.think - ChatRequest.think - Client.generate (all 3 overloads) - Client.chat (all 3 overloads) - AsyncClient.generate (all 3 overloads) - AsyncClient.chat (all 3 overloads) Also adds a regression test verifying 'max' is present in all four methods' think annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
The Go API's
ThinkValuetype accepts"max"as a valid string level (alongside"low","medium","high"), but the Python client was missing'max'from allthinkparameter annotations.This adds
'max'consistently across:GenerateRequest.think(_types.py)ChatRequest.think(_types.py)Client.generate— all 3 overloads (_client.py)Client.chat— all 3 overloads (_client.py)AsyncClient.generate— all 3 overloads (_client.py)AsyncClient.chat— all 3 overloads (_client.py)Context
Supersedes #681 which only patched
_types.pyand missed the_client.pyoverloads. This PR covers all 14 annotation sites in one pass.Testing
test_generate_think_annotation_matches_chat— updated comment, still passestest_think_max_level_accepted— new regression test verifying'max'is present in all four methods'thinkannotations@ParthSareen