Add mongocli installation to Dockerfile and update install script#34
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves installation of MongoDB’s mongocli from install-system-dependencies.sh into the base image build step in the Dockerfile, keeping the rest of the system dependency install script focused on downloaded CLI tooling.
Changes:
- Removed
mongocliinstall (and its architecture mapping) frominstall-system-dependencies.sh. - Added
mongoclidownload + local.debinstallation into the main aptRUNlayer inDockerfile. - Adjusted apt cleanup in
Dockerfileto be more complete (apt-get cleanand removal of apt lists).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install-system-dependencies.sh | Removes mongocli install steps so the script only handles the remaining CLI downloads. |
| Dockerfile | Adds mongocli installation during image build and updates apt cleanup behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MONGOCLI_ARCHITECTURE="$(dpkg --print-architecture)" && \ | ||
| if [ "${MONGOCLI_ARCHITECTURE}" = "amd64" ]; then MONGOCLI_ARCHITECTURE=x86_64; fi && \ | ||
| mkdir -p /tmp/ohio-pkgs && \ | ||
| curl -Lo /tmp/ohio-pkgs/mongocli.deb https://github.com/mongodb/mongodb-cli/releases/download/mongocli%2Fv"${MONGOCLI_VERSION}"/mongocli_"${MONGOCLI_VERSION}"_linux_"${MONGOCLI_ARCHITECTURE}".deb && \ |
Comment on lines
+12
to
+13
| # Versions for apt installation, see below for more versions. | ||
| ARG MONGOCLI_VERSION=2.0.7 |
Comment on lines
+69
to
70
| # Note: See above for more versions necessary for apt installation. | ||
| ARG SKAFFOLD_VERSION=2.13.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.