Sync feedback: Mobile runtime, clipboard, and model fixes - #628
Conversation
…rately not wired Names each fix, what to look for, and what the failure looked like before, so a partial fix cannot pass as a whole one - plus the parts that are recorded but not yet acted on, so testing for them is not wasted effort.
The rules were spread across three files: a pure filter in the message builder, an existence check private to the service, and the same `type === 'image'` test written by hand at each call site. They are one rule read at two depths - what the attachment declares, and what the filesystem can back - so they live together now, and no caller restates either half. Also removes what the safe file reader made dead: size imports and local ternaries that no longer had a caller, which the lint gate caught. The pending row becomes its own component; every other branch in that map reads `uri` and this is the one case with none.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis change centralizes filesystem test boundaries, adds Android accessibility clipboard capture, refactors vision-model repair, updates chat and image-generation flows, and expands synchronization and UI validation. ChangesRelease integration
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: 🟠 High · up to The PR changes chat generation, streaming cleanup, model repair, and image generation behavior, but the current head still contains correctness defects and a red full test gate; pending messages may be rejected, cancelled output may be saved, and model files may be mismatched. It is not merge-ready until these issues are fixed and validation passes. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
Code
Mobile changes for background clipboard capture, safe filesystem reads, llama.rn 0.13, chat and attachment identity, model vision repair, sync feedback, native model-transfer progress, loader consolidation, and coordinated Mobile Pro integration.
The final head
332c8c8balso:08ce0465Wired
879094702d7972d6c9ed01c6797998f070ff3a38222e22d707f7ea1127d4da0fa78feb581e9e4075d5aea006Verified
npx tsc --noEmitafter the dead-code repair332c8c8bpass and no blocking review remains