Conversation
The username/password login mode always authenticated against the static credentials configured via AUTH_STATIC_CREDENTIALS. The legacy Flightnet SOAP fallback was unreachable: no project set a company, so the request never carried one and the fallback always errored. Rename the mode from "flightnet" to "static", remove the SOAP client and the unused soap dependency, and drop the dead __FLIGHTNET_COMPANY__ global. Behaviour for the static-credentials path is unchanged.
Refresh resolved versions in the lockfiles to the latest minor/patch releases (Sentry, firebase, react, react-router, cypress, pdfmake, date-fns, nodemailer and others). Only lockfiles change; package.json ranges already covered these versions. Major upgrades are left out. Verified: typecheck, frontend tests, functions tests and a production build all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.