Remove `Forward constructor - #1478
Open
Leonidas-from-XIV wants to merge 2 commits into
Open
Conversation
Leonidas-from-XIV
changed the title
Forward`` constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to understand what
`Forwarddoes. To do so figure out where a value of`Forwardis constructed (from scratch, not as part of amapoperation) and see what context this is useful. But it seems that such a value is never constructed. To test my hypothesis I removed the`Forwardconstructor from the codebase and it seems to compile fine and the tests also pass.Thus my investigation seems to point to the fact that
`Forwardis unnecessary and can be removed. I'm opening a draft PR and invite maintainers to take a look - maybe I am missing some context in which`Forwardis used, but if anything then at least it points at the fact that this functionality is not covered by any tests.