Use implementations from Stdlib if available - #1476
Open
Leonidas-from-XIV wants to merge 2 commits into
Open
Conversation
Leonidas-from-XIV
force-pushed
the
use-stdlib-if-available
branch
from
August 13, 2026 08:26
cc65e39 to
2a1cf77
Compare
Contributor
|
Note it's not against your PR, but I note that for myself I would likely not do that. When additions are made to the stdlib, your own functions get automatically overriden without you noticing. I think I'd rather first check that we are on page that the semantics matches. Stuff like differences in iteration order in the implementation of functions can make it for the odd and hard to track bug that depends on which version of OCaml you installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my
include functorPR I've usedList.partition_map, which made the CI fail on OCaml 4.11, so I looked for the place where Odoc (like every project) would have its own Stdlib extensions.However the way it is currently implemented the Odoc implementations take preference over the OCaml stdlib. This is mostly fine, however it would be somewhat nicer if Odoc could profit from potential future improvements. In Dune we have arrived at a pattern which allows us to polyfill missing functions while also using the compilers implementation of them - without having to resort to conditional compilation.
This PR implements that pattern.