Skip to content

A few 4.14 updates #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmid merged 3 commits into from
May 1, 2023
Merged

A few 4.14 updates #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a6d8c3
Test opam installation on 4.14 and 5.1 too
jmid May 1, 2023
d0dc801
Document 4.14.x availability in README
jmid May 1, 2023
e426d6f
Update Flexdll issue to fixed
jmid May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/opam.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ jobs:
env:
QCHECK_MSG_INTERVAL: '60'

strategy:
matrix:
ocaml-compiler:
- 4.14.x
- 5.0.0
- ocaml-variants.5.1.0+trunk

runs-on: ubuntu-latest

steps:
Expand All @@ -24,7 +31,7 @@ jobs:
- name: Install OCaml compiler
uses: ocaml/setup-ocaml@v2
with:
ocaml-compiler: 5.0.0
ocaml-compiler: ${{ matrix.ocaml-compiler }}
opam-depext: false

- name: Test installation of the OPAM packages
Expand Down
11 changes: 6 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,16 @@ helpful](https://tarides.com/blog/2022-12-22-ocaml-5-multicore-testing-tools).
Installation instructions, and running the tests
================================================

Both the libraries and the test suite require OCaml 5.0:
The multicore test suite requires OCaml 5.0 (or newer):
```
opam update
opam switch create 5.0.0
```

The two testing libraries are available as packages `qcheck-lin`
and `qcheck-stm` from the opam repository and can be installed in
the usual way:
and `qcheck-stm` from the opam repository. The full versions require
OCaml 5.x and reduced, non-`Domain` versions are available for OCaml
4.14.x. They can be installed in the usual way:
```
opam install qcheck-lin
opam install qcheck-stm
Expand Down Expand Up @@ -362,8 +363,8 @@ Sequential `STM` tests targeting `Sys.rename` found [two corner cases
where MingW behaves differently](https://github.com/ocaml/ocaml/issues/12073)


`flexdll` contains a race condition in its handling of errors (new, flexdll)
----------------------------------------------------------------------------
`flexdll` contains a race condition in its handling of errors (new, fixed, flexdll)
-----------------------------------------------------------------------------------

Parallel `Lin` tests of the `Dynlink` module found [a race
condition](https://github.com/ocaml/flexdll/pull/112) in accesses to
Expand Down