feat: Workspace 1057#180
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 69.27% 69.05% -0.23%
==========================================
Files 217 221 +4
Lines 6305 6357 +52
==========================================
+ Hits 4368 4390 +22
- Misses 1937 1967 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
faucomte97
left a comment
There was a problem hiding this comment.
@faucomte97 reviewed 30 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on SKairinos).
codeforlife/user/models/klass.py line 108 at r1 (raw file):
name_validators: Validators = [ MaxLengthValidator(200), UnicodeAlphanumericCharSetValidator(spaces=True, special_chars="-_"),
I know we had this conversation ages ago but I don't remember.
Does this Validator allow for characters from different alphbets, e.g. Arabic, Hindi, Chinese, etc.
codeforlife/user/models/school.py line 87 at r1 (raw file):
name_validators: Validators = [ MaxLengthValidator(200), UnicodeAlphanumericCharSetValidator(
Same question
SKairinos
left a comment
There was a problem hiding this comment.
@SKairinos made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on faucomte97).
codeforlife/user/models/klass.py line 108 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
I know we had this conversation ages ago but I don't remember.
Does this Validator allow for characters from different alphbets, e.g. Arabic, Hindi, Chinese, etc.
Here is what Unicode currently includes:
-
Modern Written Languages: Everything from Latin, Cyrillic, and Greek to Arabic, Hebrew, Devanagari (Hindi), Thai, and the massive sets of CJK (Chinese, Japanese, Korean) characters.
-
Historical and Dead Scripts: You can type in Egyptian Hieroglyphs, Sumerian Cuneiform, Runes, and Linear B.
-
Indigenous and Minority Languages: It actively works to include scripts for lesser-known or indigenous languages (like Cherokee or N'Ko) so they can survive in the digital age.
-
Symbols and Emojis: Mathematical symbols, currency signs, musical notation, and all standard emojis are also part of the Unicode standard.
Currently, the Unicode standard contains over 150,000 characters covering more than 160 different scripts. Every time you see text in a non-English language on the internet today, you have Unicode to thank for it!
codeforlife/user/models/school.py line 87 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Same question
Done.
faucomte97
left a comment
There was a problem hiding this comment.
@faucomte97 made 1 comment and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on SKairinos).
faucomte97
left a comment
There was a problem hiding this comment.
@faucomte97 reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on SKairinos).
This change is