Skip to content

feat: Workspace 1057#180

Merged
SKairinos merged 14 commits into
mainfrom
workspace_1057
Jun 19, 2026
Merged

feat: Workspace 1057#180
SKairinos merged 14 commits into
mainfrom
workspace_1057

Conversation

@SKairinos

@SKairinos SKairinos commented May 15, 2026

Copy link
Copy Markdown
Contributor

This change is Reviewable

@SKairinos SKairinos linked an issue May 15, 2026 that may be closed by this pull request
@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.33333% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.05%. Comparing base (d17ef63) to head (a218eed).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
codeforlife/admin.py 0.00% 25 Missing ⚠️
codeforlife/user/models/other.py 40.00% 9 Missing ⚠️
codeforlife/legacy/helpers/emails.py 0.00% 2 Missing ⚠️
codeforlife/legacy/helpers/generators.py 33.33% 2 Missing ⚠️
codeforlife/legacy/tests/utils/student.py 0.00% 2 Missing ⚠️
codeforlife/user/models/user/user.py 88.23% 2 Missing ⚠️
codeforlife/legacy/tests/utils/user.py 0.00% 1 Missing ⚠️
codeforlife/models/fields/utils.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   69.27%   69.05%   -0.23%     
==========================================
  Files         217      221       +4     
  Lines        6305     6357      +52     
==========================================
+ Hits         4368     4390      +22     
- Misses       1937     1967      +30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SKairinos SKairinos marked this pull request as ready for review June 15, 2026 14:40

@faucomte97 faucomte97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faucomte97 reviewed 30 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on SKairinos).


codeforlife/user/models/klass.py line 108 at r1 (raw file):

    name_validators: Validators = [
        MaxLengthValidator(200),
        UnicodeAlphanumericCharSetValidator(spaces=True, special_chars="-_"),

I know we had this conversation ages ago but I don't remember.
Does this Validator allow for characters from different alphbets, e.g. Arabic, Hindi, Chinese, etc.


codeforlife/user/models/school.py line 87 at r1 (raw file):

    name_validators: Validators = [
        MaxLengthValidator(200),
        UnicodeAlphanumericCharSetValidator(

Same question

@SKairinos SKairinos left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SKairinos made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on faucomte97).


codeforlife/user/models/klass.py line 108 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

I know we had this conversation ages ago but I don't remember.
Does this Validator allow for characters from different alphbets, e.g. Arabic, Hindi, Chinese, etc.

Here is what Unicode currently includes:

  • Modern Written Languages: Everything from Latin, Cyrillic, and Greek to Arabic, Hebrew, Devanagari (Hindi), Thai, and the massive sets of CJK (Chinese, Japanese, Korean) characters.

  • Historical and Dead Scripts: You can type in Egyptian Hieroglyphs, Sumerian Cuneiform, Runes, and Linear B.

  • Indigenous and Minority Languages: It actively works to include scripts for lesser-known or indigenous languages (like Cherokee or N'Ko) so they can survive in the digital age.

  • Symbols and Emojis: Mathematical symbols, currency signs, musical notation, and all standard emojis are also part of the Unicode standard.

Currently, the Unicode standard contains over 150,000 characters covering more than 160 different scripts. Every time you see text in a non-English language on the internet today, you have Unicode to thank for it!


codeforlife/user/models/school.py line 87 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Same question

Done.

@faucomte97 faucomte97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@faucomte97 made 1 comment and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on SKairinos).

@faucomte97 faucomte97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faucomte97 reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on SKairinos).

@SKairinos SKairinos merged commit c7900df into main Jun 19, 2026
15 of 19 checks passed
@SKairinos SKairinos deleted the workspace_1057 branch June 19, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove text fields

2 participants