Skip to content

fix(components): page container registrations publish children, not the retired body (#4027) - #4070

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4027-page-container-inputs
Aug 10, 2026
Merged

fix(components): page container registrations publish children, not the retired body (#4027)#4070
yinlianghui merged 1 commit into
mainfrom
claude/issue-4027-page-container-inputs

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes #4027

inputs is the published authoring surface, not documentation: the Studio block designer builds its panel from it, sdui-parser's gen-manifest.ts serializes it into sdui.manifest.json and sdui-intrinsics.d.ts, and page.tsx builds the JSX-page prop whitelist from it. Two page:* container declarations had drifted from the contract, in opposite directions.

Retired key still offered. page:card published { name: 'body', type: 'slot' }. objectstack-ai/objectstack#5775 (PR objectstack-ai/objectstack#6281, merged 2026-08-07, ADR-0087 D2) retired PageCardProps.body and declared children in its place — one composition slot with one spelling, the one grid, flex, page:section and page:tabs items already use. The designer was teaching a key the contract now rejects by name.

Declared slot not offered at all. page:section / page:footer / page:sidebar registered with no inputs whatsoever, so nothing could authorize the child list those three components exist to render. The same upstream PR replaced their EmptyProps entries with the shared PageContainerProps, whose single key is children; all three now publish that slot from one shared literal, mirroring the spec's single definition.

Rendering is untouched — deliberately

The renderers keep READING body: PageCardRenderer still resolves schema?.body ?? schema?.children, and the three thin containers still read schema?.children || schema?.body. Documents stored under the old contract keep rendering until the ADR-0087 D2 conversion rewrites the key at load time; deleting the read now would blank an existing card's content silently. A back-compat read is not a second authorable spelling — the same split the page-header-subtitle-alias sequencing already established in packages/layout.

No validation verdict moves either, which is what keeps this to the authoring surface:

  • sdui-parser/src/validate.ts lists children in BASE_PROPS, so it was never an unknown-prop and does not become one;
  • codegen.ts:emitInterface filters slot inputs out of the generated .d.ts, where SduiBaseProps.children already types it;
  • isContainer: true was already set on all four blocks — that is what authorizes children to the parser's not-a-container check.

The pin lag, and why it did not block this

The dispatch asked this to be measured rather than assumed: objectui pins @objectstack/spec@^17.0.0-rc.5, and rc.5 predates objectstack-ai/objectstack#6281. Verified in the installed package, not inferred — node_modules/@objectstack/spec/dist/ui/index.d.ts declares PageCardProps with body and no children, exports no PageContainerProps, and still maps the three thin containers to EmptyProps.

It does not fork the fix: registration inputs are objectui-side designer descriptors (plain literals), so nothing here type-checks against a spec export. What the lag does reach is apps/console/src/__tests__/registry-inputs-spec-parity.test.ts, which derives its expectations from ComponentPropsMap at runtime and therefore reads all four correct declarations as off-spec. That file already carries six stale-pin entries from this same upstream issue (the element:record_picker trio, both directions), so the four children entries and the page:card.body entry follow that established discipline verbatim — each naming #4027 and the upstream PR, and each deleted by the gate's own no stale exemption test when the pin moves. Consistent with that file's own note: "EXPECTATIONS ARE DERIVED, NOT RESTATED … which is also how the stale-pin exemptions below are meant to resolve themselves."

Two list moves follow mechanically, both pinned rather than silent: the three containers move from EXPECTED_WITHOUT_INPUTS to EXPECTED_COVERED, and out of public-contract.test.ts's PROP_LESS_CURATED (whose "reads nothing beyond children" was doing double duty as "therefore declares nothing"). One new carve-out was needed and is self-clearing: the gate's non-empty-shape probe guard would otherwise accuse itself of being broken for three blocks whose pinned shape is legitimately {}SPEC_SHAPE_EMPTY_ON_THE_PIN, with an assertion that fails the moment those shapes stop being empty.

Tests

New pin file packages/components/src/__tests__/page-container-authorable-keys.test.tsx, both directions, asserting the merged contract literally rather than deriving from the stale pin (with the reason written down):

  • page:card does not offer body; offers children as a slot; its full input list is pinned exactly (title, bordered, children, footer) so the respelling cannot widen into a second surface;
  • each thin container declares exactly ['children'], is still isContainer, and all three share one literal;
  • the back-compat reads are pinned by rendering: a card and each container render content stored under body and under children, so the sequencing guard fails if someone "finishes the job" by deleting the read.

Reverse verification (fix removed with git checkout origin/main -- containers.tsx, restored after — never git stash): 7 of the 15 new assertions go red, and the 8 that stay green are exactly the ones that must not move (isContainer, both back-compat render paths). The console gates go red too — 7 failures across the two files.

pnpm exec vitest run packages/components/ apps/console/ --maxWorkers=2
 Test Files  138 passed (138)
      Tests  1240 passed (1240)

tsc --noEmit clean in packages/components and apps/console (after building each package's dependency closure — the stale-artifact trap otherwise reports missing .d.ts as if this change broke the imports). eslint on the four changed files: 0 errors (83 pre-existing no-explicit-any warnings in containers.tsx). pnpm check:control-bytes OK; node scripts/check-changeset-presence.mjs reports the changeset.


Generated by Claude Code

… the retired `body` (#4027)

`inputs` is the published authoring surface — the Studio designer panel,
`sdui.manifest.json`, `sdui-intrinsics.d.ts` and the JSX-page prop whitelist all
come from it — and two `page:*` container declarations had drifted from the
contract in opposite directions.

`page:card` published `{ name: 'body', type: 'slot' }`. objectstack#5775
(PR objectstack#6281, merged 2026-08-07, ADR-0087 D2) retired
`PageCardProps.body` and declared `children` in its place; the designer was
teaching a key the contract now rejects by name.

`page:section` / `page:footer` / `page:sidebar` declared no `inputs` at all, so
nothing could authorize the child list those three exist to render. The same PR
replaced their `EmptyProps` entries with the shared `PageContainerProps`, whose
single key is `children` — mirrored here as one shared literal.

Rendering is untouched in both directions: the renderers keep READING `body` for
documents stored under the old contract, which the ADR-0087 D2 conversion
rewrites at load time. A back-compat read is not a second authorable spelling.

The pinned `@objectstack/spec@17.0.0-rc.5` predates #6281, so the repo-wide
parity gate reads all four correct declarations as off-spec; they are registered
as stale-pin exemptions in both directions, alongside the `element:record_picker`
trio from the same upstream issue, and the gate's own `no stale exemption` test
deletes them when the pin moves.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Aug 10, 2026 3:57am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.1 KB 350 KB
Entry file index-DwnowQZ6.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.66KB 3.13KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.13KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.64KB 2.21KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 26.07KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.65KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 483.91KB 106.75KB
core (index.js) 3.04KB 1.15KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 139.61KB 35.99KB
fields (index.js) 228.51KB 56.69KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.65KB 1.06KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 9.48KB 3.27KB
i18n (useObjectLabel.js) 27.59KB 6.63KB
i18n (useSafeTranslation.js) 4.52KB 1.96KB
layout (index.js) 38.84KB 10.80KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.32KB 1.64KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.23KB 12.45KB
plugin-charts (index.js) 61.49KB 17.48KB
plugin-chatbot (index.js) 180.33KB 42.79KB
plugin-dashboard (index.js) 118.50KB 30.66KB
plugin-designer (index.js) 210.51KB 42.51KB
plugin-detail (index.js) 237.80KB 59.48KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 113.81KB 27.53KB
plugin-gantt (index.js) 162.79KB 39.67KB
plugin-grid (index.js) 187.97KB 49.79KB
plugin-kanban (index.js) 48.53KB 13.38KB
plugin-list (index.js) 109.73KB 26.55KB
plugin-map (index.js) 17.00KB 5.32KB
plugin-markdown (index.js) 13.72KB 4.69KB
plugin-report (index.js) 40.58KB 10.58KB
plugin-timeline (index.js) 26.21KB 7.52KB
plugin-tree (index.js) 8.50KB 2.88KB
plugin-view (index.js) 84.03KB 20.55KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 23.71KB 7.95KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.23KB 0.66KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 4.47KB 2.03KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 2.71KB 1.34KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 2.59KB 1.31KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 3.40KB 1.71KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants