docs(adr): repair 8 dead source-tree links in ADR-0004 / ADR-0020 and empty the link-gate baseline - #7343
Merged
Merged
Conversation
…mpty the link-gate baseline Fixes #6726 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YS2qzDAn3CpWdY7uBX9bFQ
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
hotlong
marked this pull request as ready for review
August 10, 2026 08:39
hotlong
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6726
All 8 dead ADR → source-tree links in ADR-0004 and ADR-0020 are repaired, and
KNOWN_DEAD_TARGETSinscripts/check-adr-links.mjsis now EMPTY — the gate from #6592 no longer ships with a grandfather clause. A follow-up may now remove the baseline mechanism entirely if the maintainer wants it gone.Premise: all 8 still dead, verified first
Every one of the 8 targets was re-checked against
origin/mainbefore any edit — all 8 still missing, and all 8 baseline entries still present. Nothing about this card had gone stale.Route taken: option (b), plain unlinked path + provenance
None of the 8 could be repointed at a live file — in every case the code genuinely left this repository, which git history confirms rather than assumes. So each link became a plain (unlinked) path in a code span, plus a short note recording where the code went. An ADR is a historical record: the path keeps the reader oriented, the note explains why there is nothing to click, and the gate has no unverifiable link to police.
packages/runtime/src/kernel-manager.tspackages/runtime/src/cloud/on 2026-05-18 (7dcde27c1), then the wholecloud/tree removed by #1600packages/runtime/src/project-kernel-factory.tscloud/artifact-kernel-factory.tsin the same commit, removed by #1600apps/studio/src/routes/projects.index.tsxapps/studio/collapsed 2026-05-22 (6bacbced2), migrated to upstream@object-ui/studio2026-05-24 (06ad57f63)apps/studio/src/routes/projects.$projectId.index.tsxpackages/spec/src/contracts/workflow-service.ts#L58workflowservice slot — this closes the[~]follow-up ADR-0020 itself left openexamples/app-crm/src/workflows/stale-opportunity.workflow.ts#L1923c710717); the reference describes the pre-ADR stateexamples/app-crm/src/flows/high-value-deal.flow.ts751cf0161(CRM slimmed to its loading-pipeline core)examples/app-crm/src/flows/stale-opportunity.flow.tsProse is otherwise untouched — only link syntax plus the added notes. ADR-0004 is
Supersededand preserved for historical context; nothing in its body was rewritten.Verification
Forward, in the gate's own enforced direction. With the 8 links fixed but the baseline still full,
check-adr-linksfailed as designed, naming all 8 as stale:That is the proof each edit removed a real dead link rather than merely a link — a repair the gate did not see would not have gone stale. The entries were then deleted in the same change.
Reverse. With the baseline empty, one link was restored and the gate went red as a new break (expected direction — an empty baseline must not absorb it):
Restored afterwards; tree clean.
Green, after merging
origin/main:The success line no longer carries its
(N frozen on the shrink-only baseline)suffix, and the census drops 531 → 523 — exactly the 8 destinations that stopped being links.eslinton the touched files: 0 errors.Notes
skip-changesetis the PM's to apply at acceptance.origin/mainmerged immediately before opening this PR; docs(adr),chore(devx): tombstone ADR-0107 — 撤回后退役的编号,附考古证据 (#6676) #7316 (ADR-0107 tombstone) touches a different record and did not touchscripts/check-adr-links.mjs.docs/adr/**PR #6741): this PR editsdocs/adr/**. Left as a draft deliberately — no ready-flip, no auto-merge.Generated by Claude Code