Skip to content

fix(scripts): re-spell check-changeset-no-major's older R control through renameRow #7342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-help merged 1 commit into from
Aug 10, 2026
+2 −3
Merged

fix(scripts): re-spell check-changeset-no-major's older R control through renameRow #7342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions scripts/check-changeset-no-major.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,10 +1078,9 @@ function selfTest() {
const oldMinor = '---\n"@objectstack/spec": minor\n---' + long;
const newMajor = '---\n"@objectstack/spec": major\n---' + long;
const { dir, base } = makeRepo({ '.changeset/old.md': oldMinor }, { '.changeset/old.md': null, '.changeset/new.md': newMajor });
const raw = git(['diff', '--name-status', base, 'HEAD', '--', '.changeset/*.md'], dir);
assert(
/^R\d/.test(raw.trim()),
`control: git must really report this as a rename, or the row below is about an ordinary add — got ${JSON.stringify(raw.trim())}`,
renameRow(dir, base, '\\.changeset/old\\.md', '\\.changeset/new\\.md') !== null,
`control: git must really pair .changeset/old.md with .changeset/new.md as a rename, or the row below is about an ordinary add — got ${JSON.stringify(git(['diff', '--name-status', base, 'HEAD', '--', '.changeset/*.md'], dir))}`,
);
const { introduced } = scan({ cwd: dir, base });
assert(
Expand Down
Loading