test(#108): cover nested @ with phi-is-not-first - #1245
Open
VasilevNStas wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@volodya-lombrozo plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #108
What
A regression test for the exact case from the issue: a nested
@attribute (
bar > @inside a child object) is covered by the existingnames/phi-is-not-firstlint.Why
The parser lifts a nested
@up to the top level of its parent, where itbecomes a
φsibling that is never first (the container always precedesit). The
phi-is-not-firstlint checks exactly that, so the confusingcode from the issue is already reported. The claim was made in
#108 (comment),
but was not backed by a test. This pack locks the behavior in, so a future
regression in the lint or in the parser would be caught by CI.
Changes
src/test/resources/org/eolang/lints/packs/single/phi-is-not-first/catches-nested-at.yaml— the new regression packBoth
mvn test(591 tests) andmvn clean install -Pqulicepass.