feat(#1100): add broad-scope lint - #1238
Open
VasilevNStas wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@yegor256 @volodya-lombrozo plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100.
Problem
A private attribute (
local) may have an excessively broad scope: it is used only inside a single nested object, while it is declared at a much higher level. This should lead to a lint warning.Solution / What
New XSLT lint
broad-scopemodeled afterredundant-object: it finds private attributes referenced (via^ξ(?:\.ρ)*\.base prefixes) exclusively within a single object different from the declaration site, and warns that the scope is too broad.Changes
src/main/resources/org/eolang/lints/design/broad-scope.xsl— the new lint.src/main/resources/org/eolang/motives/design/broad-scope.md— motivation.src/test/resources/org/eolang/lints/packs/single/broad-scope/— 3 test packs.Tests
catches-broad-scopeallows-used-on-top-levelallows-used-in-multiple-objects