fix(#297): make vocabulary thread-safe and return test-not-verb - #1234
Open
VasilevNStas wants to merge 2 commits into
Open
fix(#297): make vocabulary thread-safe and return test-not-verb#1234VasilevNStas wants to merge 2 commits into
VasilevNStas wants to merge 2 commits into
Conversation
Contributor
Author
|
@volodya-lombrozo @yegor256 plz review, I've fixed it |
volodya-lombrozo
suggested changes
Aug 13, 2026
VasilevNStas
force-pushed
the
fix/issue-297-thread-safe-test-not-verb
branch
from
August 13, 2026 15:35
99576c9 to
a25af68
Compare
Contributor
Author
|
@volodya-lombrozo I`m fixed it |
VasilevNStas
force-pushed
the
fix/issue-297-thread-safe-test-not-verb
branch
from
August 15, 2026 09:43
a25af68 to
bfea148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #297
Context. The
unit-test-is-not-verblint was disabled in #297 because it occasionally producedNullPointerExceptionwhen the EO-to-Java Compiler ran lints in parallel. The maintainers agreed to re-enable it once a thread-safety fix lands (see the@todo #297puzzle left inPkMono).Root cause: OpenNLP's
POSTaggerMEis not thread-safe: a single shared instance mutates internal state (bestSequence) on everytag()call.Vocabularykept one such instance and was invoked from multiple threads buildingeo-runtimewith lints.Fix:
Vocabularynow holds a sharedPOSModel(immutable, safe to reuse) and creates onePOSTaggerMEper thread viaThreadLocal, so concurrent calls never share mutable tagger state.LtTestNotVerb(theunit-test-is-not-verblint) inMonoLints, so it is back among the active default lints.@todo #297fromPkMono.Tests:
mvn clean install -Pqulice— 578 tests, all green, including the existing concurrentVocabularyTest,LtTestNotVerbTest, andlintsInMultipleThreads.