feat(#566): add invalid-name-notation lint - #1228
Closed
VasilevNStas wants to merge 2 commits into
Closed
Conversation
Member
|
Thanks for the contribution! These commits aren't GPG/SSH-signed, and rultor requires signed commits to merge — see GitHub's guide on signing commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Closing for now; please feel free to reopen once your commits are signed. |
Contributor
Author
|
@volodya-lombrozo, fixed — commits are now SSH-signed (verified by GitHub). Since the closed PR can't be reopened after a force-push, I've recreated it as #1235 (same change, signed commits). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #566
New lint
invalid-name-notationchecks that every@namein the XMIR matches[a-z]+(-[a-z]+)*— kebab-case, Latin letters only, no digits/underscores/uppercase, as requested in #566.src/main/resources/org/eolang/lints/names/invalid-name-notation.xsl— the lint (warning severity, samedefectshape asnon-kebab-name).src/main/resources/org/eolang/motives/names/invalid-name-notation.md— motive.eo:specialnow also recognizesξ(xi), an internal parser symbol alongsideφ/λ; otherwise parser-generated<o name="ξ"/>inside atoms would be flagged.φ,λ,a🌵N-Nauto-names and test names), allows-throwing-test-name, catches-invalid-names.canonical.eo: renamed the[i1]lambda parameter to[i]incanonical.eo— digits are now forbidden by design (confirmed by @yegor256 ininvalid-name-notationLint for@nameAttribute Matching Not Created #566).Verified:
mvn clean install -Pqulicegreen (404 LtByXslTest + all suites),mvn jmh:benchmarkpassed.