Skip to content

[TW-6572] fix(@ownmail/app): preserve nested text contrast - #299

Merged
AaronDDM merged 3 commits into
mainfrom
tw-6572-nested-surface-contrast
Aug 20, 2026
Merged

[TW-6572] fix(@ownmail/app): preserve nested text contrast#299
AaronDDM merged 3 commits into
mainfrom
tw-6572-nested-surface-contrast

Conversation

@AaronDDM

@AaronDDM AaronDDM commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • evaluate foreground colors against the nearest effective painted email surface
  • correct insufficient authored or inherited colors while preserving pairs that already meet 4.5:1 contrast
  • cache surface classification across transparent wrappers
  • add unit and real-Chromium coverage for white text inside a transformed light card

Validation

  • pnpm lint
  • pnpm --filter @ownmail/app typecheck
  • pnpm --filter @ownmail/app test
  • pnpm --filter @ownmail/app build
  • pnpm smoke:ownmail-release

Jira: https://nylas.atlassian.net/browse/TW-6572

@AaronDDM
AaronDDM marked this pull request as ready for review August 20, 2026 11:34
@AaronDDM
AaronDDM requested a review from radenkovic as a code owner August 20, 2026 11:34
@AaronDDM
AaronDDM requested a review from qasim-nylas August 20, 2026 11:34
qasim-nylas
qasim-nylas previously approved these changes Aug 20, 2026
View reviewed changes

@qasim-nylas qasim-nylas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f04567970a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread labs/ownmail/packages/app/src/features/mail/components/email-content-element.ts Outdated
Comment thread labs/ownmail/packages/app/src/features/mail/components/email-content-element.ts Outdated
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a36628388

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread labs/ownmail/packages/app/src/features/mail/components/email-content-element.ts Outdated
Comment thread labs/ownmail/packages/app/src/features/mail/components/email-content-element.ts
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 20, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c218f654ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread labs/ownmail/packages/app/src/features/mail/components/email-content-element.ts
Comment thread labs/ownmail/packages/app/src/features/mail/components/email-content-element.ts
@AaronDDM
AaronDDM enabled auto-merge (squash) August 20, 2026 17:20
@AaronDDM
AaronDDM requested a review from qasim-nylas August 20, 2026 17:20
qasim-nylas
qasim-nylas approved these changes Aug 20, 2026
View reviewed changes

@qasim-nylas qasim-nylas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AaronDDM
AaronDDM merged commit 5f50fe1 into main Aug 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@qasim-nylas qasim-nylas qasim-nylas approved these changes
@radenkovic radenkovic Awaiting requested review from radenkovic radenkovic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AaronDDM @qasim-nylas